Re: [PATCH v6 2/4] can: m_can: Rename m_can_priv to m_can_classdev

2019-03-04 Thread Wolfgang Grandegger
Am 04.03.19 um 19:14 schrieb Dan Murphy: > Wolfgang > > On 3/4/19 11:31 AM, Wolfgang Grandegger wrote: >> Hello, >> >> there are still "LTL" after renaming m_can_priv to m_can_classdev. >> > > Yes I know but some of those become unreadable if I break them apart. > > But if you want me to brea

Re: [PATCH v6 2/4] can: m_can: Rename m_can_priv to m_can_classdev

2019-03-04 Thread Dan Murphy
Wolfgang On 3/4/19 11:31 AM, Wolfgang Grandegger wrote: > Hello, > > there are still "LTL" after renaming m_can_priv to m_can_classdev. > Yes I know but some of those become unreadable if I break them apart. But if you want me to break them I can do it. For instance struct m_can_plat_

Re: [PATCH v6 2/4] can: m_can: Rename m_can_priv to m_can_classdev

2019-03-04 Thread Wolfgang Grandegger
Hello, there are still "LTL" after renaming m_can_priv to m_can_classdev. Am 01.03.19 um 19:50 schrieb Dan Murphy: > Rename the common m_can_priv class structure to > m_can_classdev as this is more descriptive. If you change the struct name, I think you should also change the variable name to so

[PATCH v6 2/4] can: m_can: Rename m_can_priv to m_can_classdev

2019-03-01 Thread Dan Murphy
Rename the common m_can_priv class structure to m_can_classdev as this is more descriptive. Signed-off-by: Dan Murphy --- v6 - No changes only rebase changes possibly can squash into the first patch - https://lore.kernel.org/patchwork/patch/1042444/ drivers/net/can/m_can/m_can.c | 94