Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-19 Thread Cong Wang
(Sorry for missing this email, it is lost in other discussions.) On Wed, Jul 11, 2018 at 8:25 AM Michel Machado wrote: > > On 07/10/2018 10:57 PM, Cong Wang wrote: > > The dev->tx_queue_len is fundamentally non-sense since now > > almost every real NIC is multi-queue and qdisc has a completely >

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-16 Thread Cong Wang
On Fri, Jul 13, 2018 at 9:39 PM Marcelo Ricardo Leitner wrote: > > On Fri, Jul 13, 2018 at 11:26:28AM -0700, Cong Wang wrote: > > On Fri, Jul 13, 2018 at 6:04 AM Marcelo Ricardo Leitner > > wrote: > > > > > > On Thu, Jul 12, 2018 at 11:05:45PM -0700, Cong Wang wrote: > > > > On Wed, Jul 11, 2018

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-16 Thread Cong Wang
On Fri, Jul 13, 2018 at 9:51 PM Marcelo Ricardo Leitner wrote: > > Well, it would help if you didn't cut out key parts of my words. Sorry about it, please allow me to copy and paste all of your words here: "Yes, but Michel wants to drop from other lower priorities if needed, and that's not possi

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-13 Thread Marcelo Ricardo Leitner
On Fri, Jul 13, 2018 at 11:17:18AM -0700, Cong Wang wrote: ... > > > > > Isn't the whole point of sch_prio offloading the queueing to > > > > > each class? If you need a limit, there is one for each child > > > > > qdisc if you use for example pfifo or bfifo (depending on you > > > > > want to limi

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-13 Thread Marcelo Ricardo Leitner
On Fri, Jul 13, 2018 at 11:26:28AM -0700, Cong Wang wrote: > On Fri, Jul 13, 2018 at 6:04 AM Marcelo Ricardo Leitner > wrote: > > > > On Thu, Jul 12, 2018 at 11:05:45PM -0700, Cong Wang wrote: > > > On Wed, Jul 11, 2018 at 12:33 PM Marcelo Ricardo Leitner > > > wrote: > > > > > > > > On Tue, Jul

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-13 Thread Cong Wang
On Fri, Jul 13, 2018 at 6:04 AM Marcelo Ricardo Leitner wrote: > > On Thu, Jul 12, 2018 at 11:05:45PM -0700, Cong Wang wrote: > > On Wed, Jul 11, 2018 at 12:33 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Tue, Jul 10, 2018 at 07:25:53PM -0700, Cong Wang wrote: > > > > On Mon, Jul 9, 2018

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-13 Thread Cong Wang
On Fri, Jul 13, 2018 at 6:00 AM Marcelo Ricardo Leitner wrote: > > On Thu, Jul 12, 2018 at 10:07:30PM -0700, Cong Wang wrote: > > On Wed, Jul 11, 2018 at 11:37 AM Marcelo Ricardo Leitner > > wrote: > > > > > > On Tue, Jul 10, 2018 at 07:32:43PM -0700, Cong Wang wrote: > > > > On Mon, Jul 9, 2018

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-13 Thread Marcelo Ricardo Leitner
On Thu, Jul 12, 2018 at 11:05:45PM -0700, Cong Wang wrote: > On Wed, Jul 11, 2018 at 12:33 PM Marcelo Ricardo Leitner > wrote: > > > > On Tue, Jul 10, 2018 at 07:25:53PM -0700, Cong Wang wrote: > > > On Mon, Jul 9, 2018 at 2:40 PM Marcelo Ricardo Leitner > > > wrote: > > > > > > > > On Mon, Jul 0

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-13 Thread Marcelo Ricardo Leitner
On Thu, Jul 12, 2018 at 10:07:30PM -0700, Cong Wang wrote: > On Wed, Jul 11, 2018 at 11:37 AM Marcelo Ricardo Leitner > wrote: > > > > On Tue, Jul 10, 2018 at 07:32:43PM -0700, Cong Wang wrote: > > > On Mon, Jul 9, 2018 at 12:53 PM Marcelo Ricardo Leitner > > > wrote: > > > > > > > > On Mon, Jul

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-12 Thread Cong Wang
On Wed, Jul 11, 2018 at 12:33 PM Marcelo Ricardo Leitner wrote: > > On Tue, Jul 10, 2018 at 07:25:53PM -0700, Cong Wang wrote: > > On Mon, Jul 9, 2018 at 2:40 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Mon, Jul 09, 2018 at 05:03:31PM -0400, Michel Machado wrote: > > > >Changing TC_P

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-12 Thread Cong Wang
On Wed, Jul 11, 2018 at 11:37 AM Marcelo Ricardo Leitner wrote: > > On Tue, Jul 10, 2018 at 07:32:43PM -0700, Cong Wang wrote: > > On Mon, Jul 9, 2018 at 12:53 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Mon, Jul 09, 2018 at 02:18:33PM -0400, Michel Machado wrote: > > > > > > > >2. s

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-11 Thread Marcelo Ricardo Leitner
On Tue, Jul 10, 2018 at 07:25:53PM -0700, Cong Wang wrote: > On Mon, Jul 9, 2018 at 2:40 PM Marcelo Ricardo Leitner > wrote: > > > > On Mon, Jul 09, 2018 at 05:03:31PM -0400, Michel Machado wrote: > > >Changing TC_PRIO_MAX from 15 to 63 risks breaking backward > > > compatibility > > > with a

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-11 Thread Marcelo Ricardo Leitner
On Tue, Jul 10, 2018 at 07:32:43PM -0700, Cong Wang wrote: > On Mon, Jul 9, 2018 at 12:53 PM Marcelo Ricardo Leitner > wrote: > > > > On Mon, Jul 09, 2018 at 02:18:33PM -0400, Michel Machado wrote: > > > > > >2. sch_prio.c does not have a global limit on the number of packets on > > > all its

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-11 Thread Michel Machado
On 07/10/2018 10:57 PM, Cong Wang wrote: On Sat, Jul 7, 2018 at 3:14 AM Nishanth Devarajan wrote: diff --git a/Documentation/networking/sch_skbprio.txt b/Documentation/networking/sch_skbprio.txt new file mode 100644 index 000..3aa4d3e --- /dev/null +++ b/Documentation/networking/sch_skbpri

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-10 Thread Cong Wang
On Sat, Jul 7, 2018 at 3:14 AM Nishanth Devarajan wrote: > diff --git a/Documentation/networking/sch_skbprio.txt > b/Documentation/networking/sch_skbprio.txt > new file mode 100644 > index 000..3aa4d3e > --- /dev/null > +++ b/Documentation/networking/sch_skbprio.txt We usually document each

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-10 Thread Cong Wang
On Mon, Jul 9, 2018 at 11:18 AM Michel Machado wrote: > 3. The queues of sch_prio.c are struct Qdisc, which don't have a > method to drop at its tail. This isn't true, you can install a qdisc which drops at tail as its child qdisc, you can install different qdiscs for different children too i

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-10 Thread Cong Wang
On Mon, Jul 9, 2018 at 12:53 PM Marcelo Ricardo Leitner wrote: > > On Mon, Jul 09, 2018 at 02:18:33PM -0400, Michel Machado wrote: > > > >2. sch_prio.c does not have a global limit on the number of packets on > > all its queues, only a limit per queue. > > It can be useful to sch_prio.c as wel

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-10 Thread Cong Wang
On Mon, Jul 9, 2018 at 2:40 PM Marcelo Ricardo Leitner wrote: > > On Mon, Jul 09, 2018 at 05:03:31PM -0400, Michel Machado wrote: > >Changing TC_PRIO_MAX from 15 to 63 risks breaking backward compatibility > > with applications. > > If done, it needs to be done carefully, indeed. I don't know

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-10 Thread Marcelo Ricardo Leitner
On Tue, Jul 10, 2018 at 10:03:22AM -0400, Michel Machado wrote: ... > > You can get 64 different priorities by stacking sch_prio, btw. And if > > you implement drop_from_tail() as part of Qdisc, you can even get it > > working for this cascading case too. > >A solution would be to add another

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-10 Thread Michel Machado
On 07/09/2018 05:40 PM, Marcelo Ricardo Leitner wrote: On Mon, Jul 09, 2018 at 05:03:31PM -0400, Michel Machado wrote: On 07/09/2018 03:53 PM, Marcelo Ricardo Leitner wrote: On Mon, Jul 09, 2018 at 02:18:33PM -0400, Michel Machado wrote: On 07/09/2018 11:44 AM, Marcelo Ricardo Leitner wrote:

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-09 Thread Marcelo Ricardo Leitner
On Mon, Jul 09, 2018 at 05:03:31PM -0400, Michel Machado wrote: > On 07/09/2018 03:53 PM, Marcelo Ricardo Leitner wrote: > > On Mon, Jul 09, 2018 at 02:18:33PM -0400, Michel Machado wrote: > > > On 07/09/2018 11:44 AM, Marcelo Ricardo Leitner wrote: > > > > On Sat, Jul 07, 2018 at 03:43:55PM +0530,

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-09 Thread Michel Machado
On 07/09/2018 03:53 PM, Marcelo Ricardo Leitner wrote: On Mon, Jul 09, 2018 at 02:18:33PM -0400, Michel Machado wrote: On 07/09/2018 11:44 AM, Marcelo Ricardo Leitner wrote: On Sat, Jul 07, 2018 at 03:43:55PM +0530, Nishanth Devarajan wrote: net/sched: add skbprio scheduer Skbprio (SKB Priori

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-09 Thread Marcelo Ricardo Leitner
On Mon, Jul 09, 2018 at 02:18:33PM -0400, Michel Machado wrote: > On 07/09/2018 11:44 AM, Marcelo Ricardo Leitner wrote: > > On Sat, Jul 07, 2018 at 03:43:55PM +0530, Nishanth Devarajan wrote: > > > net/sched: add skbprio scheduer > > > > > > Skbprio (SKB Priority Queue) is a queueing discipline t

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-09 Thread Michel Machado
On 07/09/2018 11:44 AM, Marcelo Ricardo Leitner wrote: On Sat, Jul 07, 2018 at 03:43:55PM +0530, Nishanth Devarajan wrote: net/sched: add skbprio scheduer Skbprio (SKB Priority Queue) is a queueing discipline that prioritizes packets according to their skb->priority field. Under congestion, alr

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-09 Thread Marcelo Ricardo Leitner
On Sat, Jul 07, 2018 at 03:43:55PM +0530, Nishanth Devarajan wrote: > net/sched: add skbprio scheduer > > Skbprio (SKB Priority Queue) is a queueing discipline that prioritizes packets > according to their skb->priority field. Under congestion, already-enqueued > lower > priority packets will be

[PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-07 Thread Nishanth Devarajan
net/sched: add skbprio scheduer Skbprio (SKB Priority Queue) is a queueing discipline that prioritizes packets according to their skb->priority field. Under congestion, already-enqueued lower priority packets will be dropped to make space available for higher priority packets. Skbprio was conceive