On Mon, Jul 9, 2018 at 12:53 PM Marcelo Ricardo Leitner
<marcelo.leit...@gmail.com> wrote:
>
> On Mon, Jul 09, 2018 at 02:18:33PM -0400, Michel Machado wrote:
> >
> > 2. sch_prio.c does not have a global limit on the number of packets on
> > all its queues, only a limit per queue.
>
> It can be useful to sch_prio.c as well, why not?
> prio_enqueue()
> {
> ...
> + if (count > sch->global_limit)
> + prio_tail_drop(sch); /* to be implemented */
> ret = qdisc_enqueue(skb, qdisc, to_free);
>
Isn't the whole point of sch_prio offloading the queueing to
each class? If you need a limit, there is one for each child
qdisc if you use for example pfifo or bfifo (depending on you
want to limit bytes or packets).
Also, what's your plan for backward compatibility here?
