Hi Heiko,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on sparc-next/master net/master linus/master v5.8-rc1
next-20200616]
[cannot apply to robh/for-next]
[if your patch is applied to the wrong git tree, please drop us a
On Tue, Jun 16, 2020 at 11:10:27AM +0200, Heiko Stübner wrote:
> >
> > You also need to provide a proper header posting when you repost this series
> > after fixing this bug.
>
> not sure I understand what you mean with "header posting" here.
David is requesting that you send a "0/N" email summa
Hi,
Am Dienstag, 16. Juni 2020, 03:12:25 CEST schrieb David Miller:
> From: David Miller
> Date: Mon, 15 Jun 2020 18:11:29 -0700 (PDT)
> > + return devm_phy_package_join(&phydev->mdio.dev, phydev,
> > +vsc8531->base_addr, 0);
>
> But it is still dereferenced her
From: David Miller
Date: Mon, 15 Jun 2020 18:11:29 -0700 (PDT)
> Because you removed this devm_kzalloc() code, vsc8531 is never initialized.
You also need to provide a proper header posting when you repost this series
after fixing this bug.
From: Heiko Stuebner
Date: Mon, 15 Jun 2020 16:44:59 +0200
> static int vsc8584_probe(struct phy_device *phydev)
> {
> struct vsc8531_private *vsc8531;
> + int rc;
> u32 default_mode[4] = {VSC8531_LINK_1000_ACTIVITY,
> VSC8531_LINK_100_ACTIVITY, VSC8531_LINK_ACTIVITY,
>
Hi Heiko,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on sparc-next/master net/master linus/master v5.8-rc1
next-20200615]
[cannot apply to robh/for-next]
[if your patch is applied to the wrong git tree, please drop us a
From: Heiko Stuebner
The different probe functions share a lot of code, so move the
common parts into a helper to reduce duplication.
This moves the devm_phy_package_join below the general allocation
but as all components just allocate things, this should be ok.
Suggested-by: Andrew Lunn
Signe
