From: Mao Wenan
Date: Tue, 19 Feb 2019 17:06:35 +0800
> This patch is to do code cleanup for ns83820_probe_phy().
> It deletes unused variable 'first' and commented out code.
>
> Signed-off-by: Mao Wenan
> ---
> v2->v3: delte unused variable 'first'; change subject from
> "net: ns83820: drop
> > for (i=1; i<2; i++) {
>
>
> the loop here seems also pointless, so you can eliminate i.
> (or did i muss something ?)
If you widen out your view a bit, you find all this code is inside a
#ifdef PHY_CODE_IS_FINISHED. I don't see anything which actually
defines that.
So a lot more code co
On Tue, Feb 19, 2019 at 01:42:03PM +0100, Walter Harms wrote:
>
> Am 19.02.2019 10:06, schrieb Mao Wenan:
> > -
> > for (i=1; i<2; i++) {
>
>
> the loop here seems also pointless, so you can eliminate i.
> (or did i muss something ?)
>
True. But please do it in a separate patch.
regards,
On 2019/2/19 20:42, Walter Harms wrote:
>
> Am 19.02.2019 10:06, schrieb Mao Wenan:
>> This patch is to do code cleanup for ns83820_probe_phy().
>> It deletes unused variable 'first' and commented out code.
>>
>> Signed-off-by: Mao Wenan
>> ---
>> v2->v3: delte unused variable 'first'; change
Am 19.02.2019 10:06, schrieb Mao Wenan:
> This patch is to do code cleanup for ns83820_probe_phy().
> It deletes unused variable 'first' and commented out code.
>
> Signed-off-by: Mao Wenan
> ---
> v2->v3: delte unused variable 'first'; change subject from
> "net: ns83820: drop pointless st
Am 19.02.2019 10:06, schrieb Mao Wenan:
> This patch is to do code cleanup for ns83820_probe_phy().
> It deletes unused variable 'first' and commented out code.
>
> Signed-off-by: Mao Wenan
> ---
> v2->v3: delte unused variable 'first'; change subject from
> "net: ns83820: drop pointless sta
On Tue, 19 Feb 2019, Mao Wenan wrote:
> This patch is to do code cleanup for ns83820_probe_phy().
> It deletes unused variable 'first' and commented out code.
>
> Signed-off-by: Mao Wenan
Acked-by: Julia Lawall
> ---
> v2->v3: delte unused variable 'first'; change subject from
> "net: ns
This patch is to do code cleanup for ns83820_probe_phy().
It deletes unused variable 'first' and commented out code.
Signed-off-by: Mao Wenan
---
v2->v3: delte unused variable 'first'; change subject from
"net: ns83820: drop pointless static qualifier in ns83820_probe_phy()" to
"net: ns83820:
