> +static int marvell_resume_fiber(struct phy_device *phydev)
> +{
> +int err;
> +
> +/* Resume the fiber mode first */
> +err = phy_write(phydev, MII_MARVELL_PHY_PAGE, MII_M_FIBER);
> +if (err < 0)
> +goto
Hi Andrew,
Le 13/07/2016 à 15:26, Andrew Lunn a écrit :
*
* Generic status code does not detect Fiber correctly!
@@ -906,12 +1070,17 @@ static int marvell_read_status(struct phy_device
*phydev)
int lpa;
int lpagb;
int status = 0;
+ int page, f
On Wed, Jul 13, 2016 at 11:14:21AM +0200, Charles-Antoine Couret wrote:
Hi Charles-Antoine
> >> +#define LPA_FIBER_1000HALF0x40
> >> +#define LPA_FIBER_1000FULL0x20
> >> +
> >> +#define LPA_PAUSE_FIBER 0x180
> >> +#define LPA_PAUSE_ASYM_FIBER 0x100
> >> +
> >> +#d
Le 12/07/2016 à 17:57, Andrew Lunn a écrit :
>> +#define LPA_FIBER_1000HALF 0x40
>> +#define LPA_FIBER_1000FULL 0x20
>> +
>> +#define LPA_PAUSE_FIBER 0x180
>> +#define LPA_PAUSE_ASYM_FIBER0x100
>> +
>> +#define ADVERTISE_FIBER_1000HALF0x40
>> +#define ADVERTISE_FIBER_100
Le 12/07/2016 à 17:18, Andrew Lunn a écrit :
> Hi Charles
It's Charles-Antoine. ;)
>
> It is best to submit a number of smaller patches, each doing one
> thing, than a single big patch. It makes review and discussion much
> simpler.
I'm sorry, I will fix that.
> So for example, this should be
> +#define LPA_FIBER_1000HALF 0x40
> +#define LPA_FIBER_1000FULL 0x20
> +
> +#define LPA_PAUSE_FIBER 0x180
> +#define LPA_PAUSE_ASYM_FIBER 0x100
> +
> +#define ADVERTISE_FIBER_1000HALF 0x40
> +#define ADVERTISE_FIBER_1000FULL 0x20
> +
> +#define ADVERTISE_PAUSE_FIBER
Hello,
I'm back with another patch evrsion about Marvell phys with a fiber interface.
>From the previous release, I fixed some issues reported by yours and I added
>some functions around the fiber interface to get statistics, to configure the
>aneg, etc.
Yes, to implement that, copper and fiber s
On Tue, Jul 12, 2016 at 05:00:52PM +0200, Charles-Antoine Couret wrote:
> Hello,
> I'm back with another patch evrsion about Marvell phys with a fiber interface.
> >From the previous release, I fixed some issues reported by yours and I added
> >some functions around the fiber interface to get stat
