Re: [PATCH v2 net-next 11/16] net: aquantia: extract timer cb into work job

2019-04-24 Thread Igor Russkikh
Hello Jakub, > The split into patches is slightly imperfect here. > > Patch 10 "introduces" a mutex, which nothing is using, yet. > > Patch 11 starts some async work, which the mutex is needed for. > > Patches 12 and 13 wrap other FW call sites... > > Isn't it better to squash 12 and 13 into 1

Re: [PATCH v2 net-next 11/16] net: aquantia: extract timer cb into work job

2019-04-23 Thread Jakub Kicinski
On Tue, 23 Apr 2019 13:17:55 +, Igor Russkikh wrote: > Service timer callback fetches statistics from FW and that may cause > a long delay in error cases. We also now need to use fw mutex > to prevent concurrent access to FW, thus - extract that logic > from timer callback into the job in the s

[PATCH v2 net-next 11/16] net: aquantia: extract timer cb into work job

2019-04-23 Thread Igor Russkikh
Service timer callback fetches statistics from FW and that may cause a long delay in error cases. We also now need to use fw mutex to prevent concurrent access to FW, thus - extract that logic from timer callback into the job in the separate work queue. Signed-off-by: Nikita Danilov Signed-off-by