Re: [PATCH v2 net-next 05/12] net: ethernet: genet: Fix speed selection

2018-09-11 Thread Florian Fainelli
On 09/10/2018 02:52 PM, Andrew Lunn wrote: > The phy supported speed is being used to determine if the MAC should > be configured to 100 or 1G. The masking logic is broken. Instead, look > 1G supported speeds to enable 1G MAC support. Since you likely need to respin to address the kbuild test robo

Re: [PATCH v2 net-next 05/12] net: ethernet: genet: Fix speed selection

2018-09-11 Thread Sergei Shtylyov
Hello! On 9/11/2018 12:52 AM, Andrew Lunn wrote: The phy supported speed is being used to determine if the MAC should be configured to 100 or 1G. The masking logic is broken. Instead, look Look at? 1G supported speeds to enable 1G MAC support. Signed-off-by: Andrew Lunn [...] MBR, Se

Re: [PATCH v2 net-next 05/12] net: ethernet: genet: Fix speed selection

2018-09-10 Thread Florian Fainelli
On 09/10/2018 02:52 PM, Andrew Lunn wrote: > The phy supported speed is being used to determine if the MAC should > be configured to 100 or 1G. The masking logic is broken. Instead, look > 1G supported speeds to enable 1G MAC support. > > Signed-off-by: Andrew Lunn Acked-by: Florian Fainelli L

[PATCH v2 net-next 05/12] net: ethernet: genet: Fix speed selection

2018-09-10 Thread Andrew Lunn
The phy supported speed is being used to determine if the MAC should be configured to 100 or 1G. The masking logic is broken. Instead, look 1G supported speeds to enable 1G MAC support. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/broadcom/genet/bcmmii.c | 7 +++ 1 file changed, 3 ins