On 09/10/2018 02:52 PM, Andrew Lunn wrote: > The phy supported speed is being used to determine if the MAC should > be configured to 100 or 1G. The masking logic is broken. Instead, look > 1G supported speeds to enable 1G MAC support.
Since you likely need to respin to address the kbuild test robot report of patch 10, do you mind changing the subject to: net: bcmgenet: Fix speed selection for reverse MII to match the subject prefix used throughout past submissions? Thank you! > > Signed-off-by: Andrew Lunn <and...@lunn.ch> > --- > drivers/net/ethernet/broadcom/genet/bcmmii.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c > b/drivers/net/ethernet/broadcom/genet/bcmmii.c > index b11d58f1bf45..b756fc79424e 100644 > --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c > +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c > @@ -226,11 +226,10 @@ int bcmgenet_mii_config(struct net_device *dev, bool > init) > * capabilities, use that knowledge to also configure the > * Reverse MII interface correctly. > */ > - if ((dev->phydev->supported & PHY_BASIC_FEATURES) == > - PHY_BASIC_FEATURES) > - port_ctrl = PORT_MODE_EXT_RVMII_25; > - else > + if (dev->phydev->supported & PHY_1000BT_FEATURES) > port_ctrl = PORT_MODE_EXT_RVMII_50; > + else > + port_ctrl = PORT_MODE_EXT_RVMII_25; > bcmgenet_sys_writel(priv, port_ctrl, SYS_PORT_CTRL); > break; > > -- Florian
