Re: [PATCH v2 net-next 02/16] net: aquantia: implement hwmon api for chip temperature

2019-04-24 Thread Andrew Lunn
On Wed, Apr 24, 2019 at 08:28:46AM +, Igor Russkikh wrote: > > >> +static u32 aq_hwmon_temp_config[] = { > >> + HWMON_T_INPUT | HWMON_T_LABEL, > >> + 0, > > > > It would be nice to also have > > > > HWMON_T_MAX | HWMON_T_MIN | > > HWMON_T_CRIT | HWMON_T_LCRIT | > > > > whi

Re: [PATCH v2 net-next 02/16] net: aquantia: implement hwmon api for chip temperature

2019-04-24 Thread Igor Russkikh
>> +static u32 aq_hwmon_temp_config[] = { >> +HWMON_T_INPUT | HWMON_T_LABEL, >> +0, > > It would be nice to also have > > HWMON_T_MAX | HWMON_T_MIN | > HWMON_T_CRIT | HWMON_T_LCRIT | > > which the PHY probably has. > > At gives some degree of context. A temperature on i

Re: [PATCH v2 net-next 02/16] net: aquantia: implement hwmon api for chip temperature

2019-04-23 Thread Andrew Lunn
> +static u32 aq_hwmon_temp_config[] = { > + HWMON_T_INPUT | HWMON_T_LABEL, > + 0, It would be nice to also have HWMON_T_MAX | HWMON_T_MIN | HWMON_T_CRIT | HWMON_T_LCRIT | which the PHY probably has. At gives some degree of context. A temperature on its own of say 65C is

[PATCH v2 net-next 02/16] net: aquantia: implement hwmon api for chip temperature

2019-04-23 Thread Igor Russkikh
From: Yana Esina Added support for hwmon api to fetch out chip temperature Signed-off-by: Yana Esina Signed-off-by: Nikita Danilov Signed-off-by: Igor Russkikh --- .../net/ethernet/aquantia/atlantic/Makefile | 1 + .../ethernet/aquantia/atlantic/aq_drvinfo.c | 129 ++ .