Re: [PATCH v2 net-next 0/2] net: dsa: mv88e6xxx: LAG fixes

2021-01-15 Thread Jakub Kicinski
On Sat, 16 Jan 2021 01:55:47 +0200 Vladimir Oltean wrote: > On Fri, Jan 15, 2021 at 03:46:22PM -0800, Jakub Kicinski wrote: > > On Sat, 16 Jan 2021 01:24:35 +0200 Vladimir Oltean wrote: > > > On Fri, Jan 15, 2021 at 03:02:46PM -0800, Jakub Kicinski wrote: > > > > On Fri, 15 Jan 2021 13:52:57 +0

Re: [PATCH v2 net-next 0/2] net: dsa: mv88e6xxx: LAG fixes

2021-01-15 Thread Tobias Waldekranz
On Fri, Jan 15, 2021 at 15:46, Jakub Kicinski wrote: > On Sat, 16 Jan 2021 01:24:35 +0200 Vladimir Oltean wrote: >> On Fri, Jan 15, 2021 at 03:02:46PM -0800, Jakub Kicinski wrote: >> > On Fri, 15 Jan 2021 13:52:57 +0100 Tobias Waldekranz wrote: >> > > The kernel test robot kindly pointed out tha

Re: [PATCH v2 net-next 0/2] net: dsa: mv88e6xxx: LAG fixes

2021-01-15 Thread Vladimir Oltean
On Fri, Jan 15, 2021 at 03:46:22PM -0800, Jakub Kicinski wrote: > On Sat, 16 Jan 2021 01:24:35 +0200 Vladimir Oltean wrote: > > On Fri, Jan 15, 2021 at 03:02:46PM -0800, Jakub Kicinski wrote: > > > On Fri, 15 Jan 2021 13:52:57 +0100 Tobias Waldekranz wrote: > > > > The kernel test robot kindly poin

Re: [PATCH v2 net-next 0/2] net: dsa: mv88e6xxx: LAG fixes

2021-01-15 Thread Jakub Kicinski
On Sat, 16 Jan 2021 01:24:35 +0200 Vladimir Oltean wrote: > On Fri, Jan 15, 2021 at 03:02:46PM -0800, Jakub Kicinski wrote: > > On Fri, 15 Jan 2021 13:52:57 +0100 Tobias Waldekranz wrote: > > > The kernel test robot kindly pointed out that Global 2 support in > > > mv88e6xxx is optional. > > > >

Re: [PATCH v2 net-next 0/2] net: dsa: mv88e6xxx: LAG fixes

2021-01-15 Thread Vladimir Oltean
On Fri, Jan 15, 2021 at 03:02:46PM -0800, Jakub Kicinski wrote: > On Fri, 15 Jan 2021 13:52:57 +0100 Tobias Waldekranz wrote: > > The kernel test robot kindly pointed out that Global 2 support in > > mv88e6xxx is optional. > > > > This also made me realize that we should verify that the hardware >

Re: [PATCH v2 net-next 0/2] net: dsa: mv88e6xxx: LAG fixes

2021-01-15 Thread Jakub Kicinski
On Fri, 15 Jan 2021 13:52:57 +0100 Tobias Waldekranz wrote: > The kernel test robot kindly pointed out that Global 2 support in > mv88e6xxx is optional. > > This also made me realize that we should verify that the hardware > actually supports LAG offloading before trying to configure it. > > v1 -

[PATCH v2 net-next 0/2] net: dsa: mv88e6xxx: LAG fixes

2021-01-15 Thread Tobias Waldekranz
The kernel test robot kindly pointed out that Global 2 support in mv88e6xxx is optional. This also made me realize that we should verify that the hardware actually supports LAG offloading before trying to configure it. v1 -> v2: - Do not allocate LAG ID mappings on unsupported hardware (Vladimir)