Re: [PATCH v2 net-next] net: ethernet: enc28j60: add device tree support

2016-04-25 Thread Michael Heimpold
Hi, Am Monday 25 April 2016, 08:23:26 schrieb Rob Herring: > On Sun, Apr 24, 2016 at 11:28:03PM +0200, Michael Heimpold wrote: > > The following patch adds the required match table for device tree support > > (and while at, fix the indent). It's also possible to specify the > > MAC address in the

Re: [PATCH v2 net-next] net: ethernet: enc28j60: add device tree support

2016-04-25 Thread Andrew F. Davis
On 04/25/2016 12:46 PM, Michael Heimpold wrote: > Hi, > > Am Monday 25 April 2016, 10:39:41 schrieben Sie: >> On 04/24/2016 04:28 PM, Michael Heimpold wrote: >>> - eth_hw_addr_random(dev); >>> + >>> + macaddr = of_get_mac_address(spi->dev.of_node); >>> + if (macaddr) >> >> You should also ch

Re: [PATCH v2 net-next] net: ethernet: enc28j60: add device tree support

2016-04-25 Thread Michael Heimpold
Hi, Am Monday 25 April 2016, 10:39:41 schrieben Sie: > On 04/24/2016 04:28 PM, Michael Heimpold wrote: > > The following patch adds the required match table for device tree support > > (and while at, fix the indent). It's also possible to specify the > > MAC address in the DT blob. > > > > Also a

Re: [PATCH v2 net-next] net: ethernet: enc28j60: add device tree support

2016-04-25 Thread Andrew F. Davis
On 04/24/2016 04:28 PM, Michael Heimpold wrote: > The following patch adds the required match table for device tree support > (and while at, fix the indent). It's also possible to specify the > MAC address in the DT blob. > > Also add the corresponding binding documentation file. > > Signed-off-b

Re: [PATCH v2 net-next] net: ethernet: enc28j60: add device tree support

2016-04-25 Thread Rob Herring
On Sun, Apr 24, 2016 at 11:28:03PM +0200, Michael Heimpold wrote: > The following patch adds the required match table for device tree support > (and while at, fix the indent). It's also possible to specify the > MAC address in the DT blob. > > Also add the corresponding binding documentation file.

[PATCH v2 net-next] net: ethernet: enc28j60: add device tree support

2016-04-24 Thread Michael Heimpold
The following patch adds the required match table for device tree support (and while at, fix the indent). It's also possible to specify the MAC address in the DT blob. Also add the corresponding binding documentation file. Signed-off-by: Michael Heimpold --- v2: * took care of Arnd Bergmann's r