On 04/25/2016 12:46 PM, Michael Heimpold wrote: > Hi, > > Am Monday 25 April 2016, 10:39:41 schrieben Sie: >> On 04/24/2016 04:28 PM, Michael Heimpold wrote: >>> - eth_hw_addr_random(dev); >>> + >>> + macaddr = of_get_mac_address(spi->dev.of_node); >>> + if (macaddr) >> >> You should also check if it is a valid MAC for Ethernet, recommend: >> >> if (macaddr && is_valid_ether_addr(macaddr)) >> > > But of_get_mac_address already takes care of this, see > http://lxr.free-electrons.com/source/drivers/of/of_net.c#L45 > Also it already checks whether spi->dev.of_node is populated at all. > It returns NULL in both error cases. > So I prefered to omit both test here. >
Ah, missed that, no problem here then. Hmm, I wonder how many other drivers then do this check needlessly.. Time to fire-up Coccinelle :) Andrew
