Re: [PATCH v2 net-next] inet: Remove an unnecessary argument of syn_ack_recalc().

2020-07-06 Thread Kuniyuki Iwashima
From: Eric Dumazet Date: Sun, 5 Jul 2020 10:08:08 -0700 > On 7/4/20 8:28 AM, Kuniyuki Iwashima wrote: > > Commit 0c3d79bce48034018e840468ac5a642894a521a3 ("tcp: reduce SYN-ACK > > retrans for TCP_DEFER_ACCEPT") introduces syn_ack_recalc() which decides > > if a minisock is held and a SYN+ACK i

Re: [PATCH v2 net-next] inet: Remove an unnecessary argument of syn_ack_recalc().

2020-07-05 Thread Eric Dumazet
On 7/4/20 8:28 AM, Kuniyuki Iwashima wrote: > Commit 0c3d79bce48034018e840468ac5a642894a521a3 ("tcp: reduce SYN-ACK > retrans for TCP_DEFER_ACCEPT") introduces syn_ack_recalc() which decides > if a minisock is held and a SYN+ACK is retransmitted or not. > > If rskq_defer_accept is not zero in s

[PATCH v2 net-next] inet: Remove an unnecessary argument of syn_ack_recalc().

2020-07-04 Thread Kuniyuki Iwashima
Commit 0c3d79bce48034018e840468ac5a642894a521a3 ("tcp: reduce SYN-ACK retrans for TCP_DEFER_ACCEPT") introduces syn_ack_recalc() which decides if a minisock is held and a SYN+ACK is retransmitted or not. If rskq_defer_accept is not zero in syn_ack_recalc(), max_retries always has the same value be