Re: [PATCH v2 net] stmmac: strip vlan tag on reception only for 8021q tagged frames

2018-05-24 Thread Jose Abreu
On 23-05-2018 16:00, Elad Nachman wrote: > Jose, > > I am not sure which drivers you have checked. I guess most non-networking > embedded drivers never use 802.1AD > so they stay broken unknowingly. > Specifically, I have tested Intel e1000e based card which works correctly > versus stmmac which

Re: [PATCH v2 net] stmmac: strip vlan tag on reception only for 8021q tagged frames

2018-05-23 Thread Elad Nachman
Jose, I am not sure which drivers you have checked. I guess most non-networking embedded drivers never use 802.1AD so they stay broken unknowingly. Specifically, I have tested Intel e1000e based card which works correctly versus stmmac which works incorrectly. If you check netdev.c in e1000e th

Re: [PATCH v2 net] stmmac: strip vlan tag on reception only for 8021q tagged frames

2018-05-22 Thread Jose Abreu
On 21-05-2018 17:42, Florian Fainelli wrote: > On 05/21/2018 08:48 AM, David Miller wrote: >> From: David Miller >> Date: Thu, 17 May 2018 12:43:56 -0400 (EDT) >> >>> Giuseppe and Alexandre, please review this patch. >> If nobody thinks this patch is important enough to actually >> review, I'm tos

Re: [PATCH v2 net] stmmac: strip vlan tag on reception only for 8021q tagged frames

2018-05-21 Thread Florian Fainelli
On 05/21/2018 08:48 AM, David Miller wrote: > From: David Miller > Date: Thu, 17 May 2018 12:43:56 -0400 (EDT) > >> Giuseppe and Alexandre, please review this patch. > > If nobody thinks this patch is important enough to actually > review, I'm tossing it. > > Sorry. > How about looping in Jos

Re: [PATCH v2 net] stmmac: strip vlan tag on reception only for 8021q tagged frames

2018-05-21 Thread David Miller
From: David Miller Date: Thu, 17 May 2018 12:43:56 -0400 (EDT) > Giuseppe and Alexandre, please review this patch. If nobody thinks this patch is important enough to actually review, I'm tossing it. Sorry.

Re: [PATCH v2 net] stmmac: strip vlan tag on reception only for 8021q tagged frames

2018-05-17 Thread David Miller
From: Elad Nachman Date: Fri, 11 May 2018 10:31:40 +0300 > stmmac reception handler calls stmmac_rx_vlan() to strip the vlan > before calling napi_gro_receive(). > > The function assumes VLAN tagged frames are always tagged with > 802.1Q protocol, and assigns ETH_P_8021Q to the skb by hard-codin

[PATCH v2 net] stmmac: strip vlan tag on reception only for 8021q tagged frames

2018-05-11 Thread Elad Nachman
stmmac reception handler calls stmmac_rx_vlan() to strip the vlan before calling napi_gro_receive(). The function assumes VLAN tagged frames are always tagged with 802.1Q protocol, and assigns ETH_P_8021Q to the skb by hard-coding the parameter on call to __vlan_hwaccel_put_tag() without checkin