On 21-05-2018 17:42, Florian Fainelli wrote: > On 05/21/2018 08:48 AM, David Miller wrote: >> From: David Miller <da...@davemloft.net> >> Date: Thu, 17 May 2018 12:43:56 -0400 (EDT) >> >>> Giuseppe and Alexandre, please review this patch. >> If nobody thinks this patch is important enough to actually >> review, I'm tossing it. >> >> Sorry. >> > How about looping in Jose?
Thanks for the cc Florian! Elad, Looking at this patch I have a couple of questions and suggestions: I see that most drivers use this pattern so, are they all broken? or is this a special case? You can also get the inner/outer vlan tag by reading desc0 of receive descriptor. Which can make this completely agnostic of VLAN tag. Thanks and Best Regards, Jose Miguel Abreu