Re: [PATCH v2 net] staging: octeon: repair "fixed-link" support

2020-10-17 Thread Andrew Lunn
> --- a/drivers/staging/octeon/ethernet.c > +++ b/drivers/staging/octeon/ethernet.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -892,6 +893,14 @@ static int cvm_oct_probe(struct platform_device *pdev) >

Re: [PATCH v2 net] staging: octeon: repair "fixed-link" support

2020-10-17 Thread Andrew Lunn
> + if (priv->of_node && > of_phy_is_fixed_link(priv->of_node)) { > + if (of_phy_register_fixed_link(priv->of_node)) { > + netdev_err(dev, "Failed to register > fixed link for interface %d, port %d\n", > +

[PATCH v2 net] staging: octeon: repair "fixed-link" support

2020-10-16 Thread Alexander A Sverdlin
From: Alexander Sverdlin The PHYs must be registered once in device probe function, not in device open callback because it's only possible to register them once. Fixes: a25e278020 ("staging: octeon: support fixed-link phys") Signed-off-by: Alexander Sverdlin --- drivers/staging/octeon/ethernet