> +                     if (priv->of_node && 
> of_phy_is_fixed_link(priv->of_node)) {
> +                             if (of_phy_register_fixed_link(priv->of_node)) {
> +                                     netdev_err(dev, "Failed to register 
> fixed link for interface %d, port %d\n",
> +                                                interface, priv->port);
> +                                     dev->netdev_ops = NULL;
> +                             }
> +                     }
> +
>                       if (!dev->netdev_ops) {
>                               free_netdev(dev);

Setting dev->netdev_ops to NULL to indicate an error is pretty
odd. But this is staging. How about cleaning this
up. of_phy_register_fixed_link() returns an -errno which you should
return.

        Andrew

Reply via email to