Re: [PATCH v2 5/6] net: dsa: add missing calls in dsa_switch_destroy

2015-10-29 Thread Neil Armstrong
On 10/29/2015 03:00 PM, Andrew Lunn wrote: > On Thu, Oct 29, 2015 at 02:23:25PM +0100, Neil Armstrong wrote: >> >> +netif_carrier_off(ds->ports[port]); >> unregister_netdev(ds->ports[port]); >> +phy_disconnect(p->phy); >> free_netdev(ds->ports[port]

Re: [PATCH v2 5/6] net: dsa: add missing calls in dsa_switch_destroy

2015-10-29 Thread Andrew Lunn
On Thu, Oct 29, 2015 at 02:23:25PM +0100, Neil Armstrong wrote: > Add missing netif_carrier_off and phy_disconnect calls to the > dsa_switch_destroy function to make sure the netdev and phy > ressources are clean before complete removal. > > Signed-off-by: Frode Isaksen > Signed-off-by: Neil Arms

Re: [PATCH v2 5/6] net: dsa: add missing calls in dsa_switch_destroy

2015-10-29 Thread kbuild test robot
Hi Neil, [auto build test ERROR on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Neil-Armstrong/Further-fix-for-dsa-unbinding/20151029-212633 config: x86_64-randconfig-x010-201543 (attached a

[PATCH v2 5/6] net: dsa: add missing calls in dsa_switch_destroy

2015-10-29 Thread Neil Armstrong
Add missing netif_carrier_off and phy_disconnect calls to the dsa_switch_destroy function to make sure the netdev and phy ressources are clean before complete removal. Signed-off-by: Frode Isaksen Signed-off-by: Neil Armstrong --- net/dsa/dsa.c | 2 ++ 1 file changed, 2 insertions(+) diff --gi