Re: [PATCH v2 0/3] ethtool: fix use of SPEED_UNKNOWN constant

2019-04-08 Thread David Miller
From: Michael Zhivich Date: Mon, 8 Apr 2019 10:48:44 -0400 > This patch series addresses 2 related issues: > > 1. ethtool_validate_speed() triggers a "signed-unsigned comparison" > warning due to type difference of SPEED_UNKNOWN constant (int) > and argument to ethtool_validate_speed (__u32). >

Re: [PATCH v2 0/3] ethtool: fix use of SPEED_UNKNOWN constant

2019-04-08 Thread Zhivich, Michael
On 4/8/19, 1:55 PM, "Andrew Lunn" wrote: >On Mon, Apr 08, 2019 at 10:48:44AM -0400, Michael Zhivich wrote: >> This patch series addresses 2 related issues: >> >> 1. ethtool_validate_speed() triggers a "signed-unsigned comparison" >> warning due to type difference of SPEED_UNKNOWN constant (int)

Re: [PATCH v2 0/3] ethtool: fix use of SPEED_UNKNOWN constant

2019-04-08 Thread Andrew Lunn
On Mon, Apr 08, 2019 at 10:48:44AM -0400, Michael Zhivich wrote: > This patch series addresses 2 related issues: > > 1. ethtool_validate_speed() triggers a "signed-unsigned comparison" > warning due to type difference of SPEED_UNKNOWN constant (int) > and argument to ethtool_validate_speed (__u32)

[PATCH v2 0/3] ethtool: fix use of SPEED_UNKNOWN constant

2019-04-08 Thread Michael Zhivich
This patch series addresses 2 related issues: 1. ethtool_validate_speed() triggers a "signed-unsigned comparison" warning due to type difference of SPEED_UNKNOWN constant (int) and argument to ethtool_validate_speed (__u32). 2. some drivers use u16 storage for SPEED_UNKNOWN constant, resulting i