On 4/8/19, 1:55 PM, "Andrew Lunn" <and...@lunn.ch> wrote: >On Mon, Apr 08, 2019 at 10:48:44AM -0400, Michael Zhivich wrote: >> This patch series addresses 2 related issues: >> >> 1. ethtool_validate_speed() triggers a "signed-unsigned comparison" >> warning due to type difference of SPEED_UNKNOWN constant (int) >> and argument to ethtool_validate_speed (__u32). >> >> 2. some drivers use u16 storage for SPEED_UNKNOWN constant, >> resulting in value truncation and thus failure to test against >> SPEED_UNKNOWN correctly. >> >> This revised series addresses several feedback comments: >> - split up the patch in to series >> - do not unnecessarily change drivers that use "int" storage >> for speed values > >Hi Michael > >Your v1 had some changes which changed plain int value speeds to using >the SPEED_X macros. Those changes appear to of disappeared. You could >submit them as well. > > Thanks > Andrew
Hi Andrew, I dropped those changes since they were purely cosmetic and not required for this patch series. I'll resubmit that set of changes as a separate patch. Thanks, ~ Michael
