Re: [PATCH v2] stmmac: fix pointer check after utilization in stmmac_interrupt

2020-05-04 Thread David Miller
From: Maxim Petrov Date: Mon, 4 May 2020 09:26:43 +0300 > The paranoidal pointer check in IRQ handler looks very strange - it > really protects us only against bogus drivers which request IRQ line > with null pointer dev_id. However, the code fragment is incorrect > because the dev pointer is use

Re: [PATCH v2] stmmac: fix pointer check after utilization in stmmac_interrupt

2020-05-04 Thread Markus Elfring
> … However, the code fragment is incorrect > because the dev pointer is used before the actual check I find such information interesting. > which leads to undefined behavior. … I suggest to adjust the wording for this “conclusion”. Regards, Markus

[PATCH v2] stmmac: fix pointer check after utilization in stmmac_interrupt

2020-05-03 Thread Maxim Petrov
The paranoidal pointer check in IRQ handler looks very strange - it really protects us only against bogus drivers which request IRQ line with null pointer dev_id. However, the code fragment is incorrect because the dev pointer is used before the actual check which leads to undefined behavior. Remov