RE: [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN

2021-01-20 Thread ashid...@fujitsu.com
Hi Andrew > The parameter is called 'forced-slave'. See the man page: Umm... # ./ethtool --help ethtool [ FLAGS ] -s|--change DEVNAME Change generic options [ speed %d ] [ duplex half|full ] [ port tp|aui|bnc|mii|fibre|da ]

Re: [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN

2021-01-19 Thread Andrew Lunn
On Mon, Jan 18, 2021 at 10:17:04AM +, ashid...@fujitsu.com wrote: > Hi Andrew > > > > Do you know how to switch between master/slave? > > > > There was a patch to ethtool merged for this: > > > > commit 558f7cc33daf82f945af432c79db40edcbe0dad0 > > Author: Oleksij Rempel > > Date: Wed Jun

RE: [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN

2021-01-18 Thread ashid...@fujitsu.com
Hi Andrew > > Do you know how to switch between master/slave? > > There was a patch to ethtool merged for this: > > commit 558f7cc33daf82f945af432c79db40edcbe0dad0 > Author: Oleksij Rempel > Date: Wed Jun 10 10:37:43 2020 +0200 > > netlink: add master/slave configuration support I know

Re: [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN

2021-01-14 Thread Andrew Lunn
On Thu, Jan 14, 2021 at 08:38:12AM +, ashid...@fujitsu.com wrote: > Hi Andrew > > > For T1, it seems like Master is pretty important. Do you have > > information to be able to return the current Master/slave > > configuration, or allow it to be configured? See the nxp-tja11xx.c for > > an exam

RE: [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN

2021-01-14 Thread ashid...@fujitsu.com
Hi Andrew > For T1, it seems like Master is pretty important. Do you have > information to be able to return the current Master/slave > configuration, or allow it to be configured? See the nxp-tja11xx.c for > an example. Do you know how to switch between master/slave? The help of the ethtool comm

RE: [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN

2021-01-12 Thread ashid...@fujitsu.com
> > I think it's possible to return a Master/Slave configuration. > > Great. It would be good to add it. OK. I think it will take some time to implement this feature, as we prioritize investigating comments from Russell. > > By the way, do you need the cable test function as implementedin > > nx

Re: [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN

2021-01-12 Thread Andrew Lunn
On Tue, Jan 12, 2021 at 05:14:21AM +, ashid...@fujitsu.com wrote: > > For T1, it seems like Master is pretty important. Do you have > > information to be able to return the current Master/slave > > configuration, or allow it to be configured? See the nxp-tja11xx.c > > for an example. > > I thi

RE: [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN

2021-01-11 Thread ashid...@fujitsu.com
> For T1, it seems like Master is pretty important. Do you have > information to be able to return the current Master/slave > configuration, or allow it to be configured? See the nxp-tja11xx.c > for an example. I think it's possible to return a Master/Slave configuration. By the way, do you need

Re: [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN

2021-01-10 Thread Andrew Lunn
On Sun, Jan 10, 2021 at 05:52:21PM +0900, Yuusuke Ashizuka wrote: > RTL9000AA/AN as 100BASE-T1 is following: > - 100 Mbps > - Full duplex > - Link Status Change Interrupt Hi Yuusuke For T1, it seems like Master is pretty important. Do you have information to be able to return the current Master/s

Re: [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN

2021-01-10 Thread Russell King - ARM Linux admin
On Sun, Jan 10, 2021 at 05:52:21PM +0900, Yuusuke Ashizuka wrote: > RTL9000AA/AN as 100BASE-T1 is following: > - 100 Mbps > - Full duplex > - Link Status Change Interrupt > > Signed-off-by: Yuusuke Ashizuka > Signed-off-by: Torii Kenichi Not a review comment on your patch, but, we really need t

[PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN

2021-01-10 Thread Yuusuke Ashizuka
RTL9000AA/AN as 100BASE-T1 is following: - 100 Mbps - Full duplex - Link Status Change Interrupt Signed-off-by: Yuusuke Ashizuka Signed-off-by: Torii Kenichi --- v2: - Remove the use of .ack_interrupt() - Implement .handle_interrupt() callback - Remove the slash from driver name --- drivers/net