On Sun, Jan 10, 2021 at 05:52:21PM +0900, Yuusuke Ashizuka wrote: > RTL9000AA/AN as 100BASE-T1 is following: > - 100 Mbps > - Full duplex > - Link Status Change Interrupt > > Signed-off-by: Yuusuke Ashizuka <ashid...@fujitsu.com> > Signed-off-by: Torii Kenichi <torii.k...@fujitsu.com>
Not a review comment on your patch, but, we really need to do something with the way phylib handles configuration changes - we have the current situation where config_aneg() _will_ get called for PHYs like this that do not support autonegotiation if userspace attempts to enable autoneg - there is nothing in phy_ethtool_ksettings_set() that prevents this. Returning an error from config_aneg() achieves nothing, and resetting the settings in config_init() also does nothing to avoid autonegotiation being enabled. I think we need phy_ethtool_ksettings_set() to check whether ETHTOOL_LINK_MODE_Autoneg_BIT is set in phydev->supported before allowing the AUTONEG_ENABLE case. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
