Re: [PATCH v2] bnx2x: disable GSO where gso_size is too big for hardware

2018-01-15 Thread Daniel Axtens
David Miller writes: > From: Daniel Axtens > Date: Fri, 12 Jan 2018 10:59:05 +1100 > >> If a bnx2x card is passed a GSO packet with a gso_size larger than >> ~9700 bytes, it will cause a firmware error that will bring the card >> down: >> >> bnx2x: [bnx2x_attn_int_deasserted3:4323(enP24p1s0f0)]

Re: [PATCH v2] bnx2x: disable GSO where gso_size is too big for hardware

2018-01-15 Thread Stephen Hemminger
On Fri, 12 Jan 2018 09:53:23 -0200 Marcelo Ricardo Leitner wrote: > On Fri, Jan 12, 2018 at 09:48:44AM -0200, Marcelo Ricardo Leitner wrote: > > On Fri, Jan 12, 2018 at 10:59:05AM +1100, Daniel Axtens wrote: > > > If a bnx2x card is passed a GSO packet with a gso_size larger than > > > ~9700 by

Re: [PATCH v2] bnx2x: disable GSO where gso_size is too big for hardware

2018-01-15 Thread David Miller
From: Daniel Axtens Date: Fri, 12 Jan 2018 10:59:05 +1100 > If a bnx2x card is passed a GSO packet with a gso_size larger than > ~9700 bytes, it will cause a firmware error that will bring the card > down: > > bnx2x: [bnx2x_attn_int_deasserted3:4323(enP24p1s0f0)]MC assert! > bnx2x: [bnx2x_mc_ass

RE: [PATCH v2] bnx2x: disable GSO where gso_size is too big for hardware

2018-01-15 Thread Chopra, Manish
H v2] bnx2x: disable GSO where gso_size is too big for hardware > > If a bnx2x card is passed a GSO packet with a gso_size larger than > ~9700 bytes, it will cause a firmware error that will bring the card > down: > > bnx2x: [bnx2x_attn_int_deasserted3:4323(enP24p1s0f0)]MC assert!

Re: [PATCH v2] bnx2x: disable GSO where gso_size is too big for hardware

2018-01-12 Thread Marcelo Ricardo Leitner
On Fri, Jan 12, 2018 at 09:48:44AM -0200, Marcelo Ricardo Leitner wrote: > On Fri, Jan 12, 2018 at 10:59:05AM +1100, Daniel Axtens wrote: > > If a bnx2x card is passed a GSO packet with a gso_size larger than > > ~9700 bytes, it will cause a firmware error that will bring the card > > down: > > Wh

Re: [PATCH v2] bnx2x: disable GSO where gso_size is too big for hardware

2018-01-12 Thread Marcelo Ricardo Leitner
On Fri, Jan 12, 2018 at 10:59:05AM +1100, Daniel Axtens wrote: > If a bnx2x card is passed a GSO packet with a gso_size larger than > ~9700 bytes, it will cause a firmware error that will bring the card > down: Why not use netif_set_gso_max_size() instead? Some drivers are using it to avoid such l

[PATCH v2] bnx2x: disable GSO where gso_size is too big for hardware

2018-01-11 Thread Daniel Axtens
If a bnx2x card is passed a GSO packet with a gso_size larger than ~9700 bytes, it will cause a firmware error that will bring the card down: bnx2x: [bnx2x_attn_int_deasserted3:4323(enP24p1s0f0)]MC assert! bnx2x: [bnx2x_mc_assert:720(enP24p1s0f0)]XSTORM_ASSERT_LIST_INDEX 0x2 bnx2x: [bnx2x_mc_asser