On Fri, 12 Jan 2018 09:53:23 -0200 Marcelo Ricardo Leitner <marcelo.leit...@gmail.com> wrote:
> On Fri, Jan 12, 2018 at 09:48:44AM -0200, Marcelo Ricardo Leitner wrote: > > On Fri, Jan 12, 2018 at 10:59:05AM +1100, Daniel Axtens wrote: > > > If a bnx2x card is passed a GSO packet with a gso_size larger than > > > ~9700 bytes, it will cause a firmware error that will bring the card > > > down: > > > > Why not use netif_set_gso_max_size() instead? > > Some drivers are using it to avoid such larger than supported packets. > > Scratch that, sorry. It doesn't take effect in forwarding path. > > Marcelo It still makes sense to tell TCP not to generate huge GSO packets. For the forwarding path, there needs to be some software recovery logic in net transmit path.