Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-26 Thread Florian Fainelli
On 2/26/2021 8:14 AM, Daniel González Cabanelas wrote: > I could update the BCM5365 phy_id in the downstream B53 driver to fix > it and avoid any kind of future conflicts if the driver is upstreamed. > Accordingly to documentation the whole BCM5365 UID (not masked) is > 0x00406370. > PHYID HIGH[

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-26 Thread Daniel González Cabanelas
I could update the BCM5365 phy_id in the downstream B53 driver to fix it and avoid any kind of future conflicts if the driver is upstreamed. Accordingly to documentation the whole BCM5365 UID (not masked) is 0x00406370. PHYID HIGH[15:0] = OUI[21:6] PHYID LOW[15:0] = OUI[5:0] + MODEL[5:0] + REV[3:0]

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-26 Thread Heiner Kallweit
On 26.02.2021 15:16, Andrew Lunn wrote: >>> OK, I see. Then there's no reason to complain upstream. >>> Either use the mainline B53 DSA driver of fix interrupt mode >>> downstream. >> >> I agree. >> >> This b53 driver has one PHY with the same BCM63XX phy_id, causing a >> double probe. I'll send th

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-26 Thread Andrew Lunn
> > OK, I see. Then there's no reason to complain upstream. > > Either use the mainline B53 DSA driver of fix interrupt mode > > downstream. > > I agree. > > This b53 driver has one PHY with the same BCM63XX phy_id, causing a > double probe. I'll send the original patch to the OpenWrt project. H

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-26 Thread Daniel González Cabanelas
El vie, 26 feb 2021 a las 11:08, Heiner Kallweit () escribió: > > On 26.02.2021 10:49, Daniel González Cabanelas wrote: > > El vie, 26 feb 2021 a las 10:32, Heiner Kallweit > > () escribió: > >> > >> On 26.02.2021 10:10, Daniel González Cabanelas wrote: > >>> El vie, 26 feb 2021 a las 8:13, Heiner

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-26 Thread Heiner Kallweit
On 26.02.2021 10:49, Daniel González Cabanelas wrote: > El vie, 26 feb 2021 a las 10:32, Heiner Kallweit > () escribió: >> >> On 26.02.2021 10:10, Daniel González Cabanelas wrote: >>> El vie, 26 feb 2021 a las 8:13, Heiner Kallweit >>> () escribió: On 25.02.2021 23:28, Daniel González Cab

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-26 Thread Daniel González Cabanelas
El vie, 26 feb 2021 a las 10:32, Heiner Kallweit () escribió: > > On 26.02.2021 10:10, Daniel González Cabanelas wrote: > > El vie, 26 feb 2021 a las 8:13, Heiner Kallweit > > () escribió: > >> > >> On 25.02.2021 23:28, Daniel González Cabanelas wrote: > >>> El jue, 25 feb 2021 a las 21:05, Heiner

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-26 Thread Heiner Kallweit
On 26.02.2021 10:32, Heiner Kallweit wrote: > On 26.02.2021 10:10, Daniel González Cabanelas wrote: >> El vie, 26 feb 2021 a las 8:13, Heiner Kallweit >> () escribió: >>> >>> On 25.02.2021 23:28, Daniel González Cabanelas wrote: El jue, 25 feb 2021 a las 21:05, Heiner Kallweit () escribió

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-26 Thread Heiner Kallweit
On 26.02.2021 10:10, Daniel González Cabanelas wrote: > El vie, 26 feb 2021 a las 8:13, Heiner Kallweit > () escribió: >> >> On 25.02.2021 23:28, Daniel González Cabanelas wrote: >>> El jue, 25 feb 2021 a las 21:05, Heiner Kallweit >>> () escribió: On 25.02.2021 17:36, Daniel González Cab

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-26 Thread Daniel González Cabanelas
El vie, 26 feb 2021 a las 8:13, Heiner Kallweit () escribió: > > On 25.02.2021 23:28, Daniel González Cabanelas wrote: > > El jue, 25 feb 2021 a las 21:05, Heiner Kallweit > > () escribió: > >> > >> On 25.02.2021 17:36, Daniel González Cabanelas wrote: > >>> El jue, 25 feb 2021 a las 8:22, Heiner K

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-25 Thread Heiner Kallweit
On 25.02.2021 23:28, Daniel González Cabanelas wrote: > El jue, 25 feb 2021 a las 21:05, Heiner Kallweit > () escribió: >> >> On 25.02.2021 17:36, Daniel González Cabanelas wrote: >>> El jue, 25 feb 2021 a las 8:22, Heiner Kallweit >>> () escribió: On 25.02.2021 00:54, Daniel González Cab

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-25 Thread Florian Fainelli
On 2/25/2021 2:56 PM, Heiner Kallweit wrote: > It's still an ugly workaround and a proper root cause analysis should be > done > first. I can only imagine that phydev->irq is overwritten in phy_probe() > because phy_drv_supports_irq() is false. Can you please check whether >

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-25 Thread Heiner Kallweit
On 25.02.2021 23:28, Daniel González Cabanelas wrote: > El jue, 25 feb 2021 a las 21:05, Heiner Kallweit > () escribió: >> >> On 25.02.2021 17:36, Daniel González Cabanelas wrote: >>> El jue, 25 feb 2021 a las 8:22, Heiner Kallweit >>> () escribió: On 25.02.2021 00:54, Daniel González Cab

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-25 Thread Daniel González Cabanelas
El jue, 25 feb 2021 a las 21:05, Heiner Kallweit () escribió: > > On 25.02.2021 17:36, Daniel González Cabanelas wrote: > > El jue, 25 feb 2021 a las 8:22, Heiner Kallweit > > () escribió: > >> > >> On 25.02.2021 00:54, Daniel González Cabanelas wrote: > >>> El mié, 24 feb 2021 a las 23:01, Florian

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-25 Thread Heiner Kallweit
On 25.02.2021 17:36, Daniel González Cabanelas wrote: > El jue, 25 feb 2021 a las 8:22, Heiner Kallweit > () escribió: >> >> On 25.02.2021 00:54, Daniel González Cabanelas wrote: >>> El mié, 24 feb 2021 a las 23:01, Florian Fainelli >>> () escribió: On 2/24/2021 1:44 PM, Heiner

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-25 Thread Daniel González Cabanelas
El jue, 25 feb 2021 a las 8:22, Heiner Kallweit () escribió: > > On 25.02.2021 00:54, Daniel González Cabanelas wrote: > > El mié, 24 feb 2021 a las 23:01, Florian Fainelli > > () escribió: > >> > >> > >> > >> On 2/24/2021 1:44 PM, Heiner Kallweit wrote: > >>> On 24.02.2021 16:44, Daniel González C

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-25 Thread Andrew Lunn
On Wed, Feb 24, 2021 at 04:44:18PM +0100, Daniel González Cabanelas wrote: > The current bcm63xx_enet driver doesn't asign the internal phy IRQ. As a > result of this it works in polling mode. > > Fix it using the phy_device structure to assign the platform IRQ. > > Tested under a BCM6348 board.

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-24 Thread Heiner Kallweit
On 25.02.2021 00:54, Daniel González Cabanelas wrote: > El mié, 24 feb 2021 a las 23:01, Florian Fainelli > () escribió: >> >> >> >> On 2/24/2021 1:44 PM, Heiner Kallweit wrote: >>> On 24.02.2021 16:44, Daniel González Cabanelas wrote: The current bcm63xx_enet driver doesn't asign the internal

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-24 Thread Daniel González Cabanelas
El mié, 24 feb 2021 a las 23:01, Florian Fainelli () escribió: > > > > On 2/24/2021 1:44 PM, Heiner Kallweit wrote: > > On 24.02.2021 16:44, Daniel González Cabanelas wrote: > >> The current bcm63xx_enet driver doesn't asign the internal phy IRQ. As a > >> result of this it works in polling mode. >

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-24 Thread Florian Fainelli
On 2/24/2021 1:44 PM, Heiner Kallweit wrote: > On 24.02.2021 16:44, Daniel González Cabanelas wrote: >> The current bcm63xx_enet driver doesn't asign the internal phy IRQ. As a >> result of this it works in polling mode. >> >> Fix it using the phy_device structure to assign the platform IRQ. >>

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-24 Thread Heiner Kallweit
On 24.02.2021 16:44, Daniel González Cabanelas wrote: > The current bcm63xx_enet driver doesn't asign the internal phy IRQ. As a > result of this it works in polling mode. > > Fix it using the phy_device structure to assign the platform IRQ. > > Tested under a BCM6348 board. Kernel dmesg before t

[PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-24 Thread Daniel González Cabanelas
The current bcm63xx_enet driver doesn't asign the internal phy IRQ. As a result of this it works in polling mode. Fix it using the phy_device structure to assign the platform IRQ. Tested under a BCM6348 board. Kernel dmesg before the patch: Broadcom BCM63XX (1) bcm63xx_enet-0:01: attached PHY