Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-15 Thread Doug Ledford
On Tue, 2018-05-15 at 19:59 +0300, Leon Romanovsky wrote: > On Tue, May 15, 2018 at 12:35:34PM -0400, Doug Ledford wrote: > > On Mon, 2018-05-14 at 09:51 -0500, Steve Wise wrote: > > > > > > On 5/13/2018 8:24 AM, Leon Romanovsky wrote: > > > > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise w

RE: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-15 Thread Steve Wise
> > On Tue, May 15, 2018 at 12:35:34PM -0400, Doug Ledford wrote: > > On Mon, 2018-05-14 at 09:51 -0500, Steve Wise wrote: > > > > > > On 5/13/2018 8:24 AM, Leon Romanovsky wrote: > > > > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: > > > > > This enhancement allows printing rdma de

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-15 Thread Leon Romanovsky
On Tue, May 15, 2018 at 12:35:34PM -0400, Doug Ledford wrote: > On Mon, 2018-05-14 at 09:51 -0500, Steve Wise wrote: > > > > On 5/13/2018 8:24 AM, Leon Romanovsky wrote: > > > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: > > > > This enhancement allows printing rdma device-specific s

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-15 Thread Doug Ledford
On Mon, 2018-05-14 at 09:51 -0500, Steve Wise wrote: > > On 5/13/2018 8:24 AM, Leon Romanovsky wrote: > > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: > > > This enhancement allows printing rdma device-specific state, if provided > > > by the kernel. This is done in a generic manne

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-15 Thread Jason Gunthorpe
On Tue, May 15, 2018 at 10:02:08AM -0500, Steve Wise wrote: > > On Tue, May 15, 2018 at 09:31:27AM -0500, Steve Wise wrote: > > > > cap net admin is not high enough privledge to see unhashed kernel > > > > pointers. CAP_RAW_IO? Or follow what printk does? > > > > > > > > > > Do you mean CAP_NET_RAW

RE: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-15 Thread Steve Wise
> On Tue, May 15, 2018 at 09:31:27AM -0500, Steve Wise wrote: > > > cap net admin is not high enough privledge to see unhashed kernel > > > pointers. CAP_RAW_IO? Or follow what printk does? > > > > > > > Do you mean CAP_NET_RAW? Here's the comments for it: > > Nope.. > > > Func restricted_pointe

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-15 Thread Jason Gunthorpe
On Tue, May 15, 2018 at 09:31:27AM -0500, Steve Wise wrote: > > cap net admin is not high enough privledge to see unhashed kernel > > pointers. CAP_RAW_IO? Or follow what printk does? > > > > Do you mean CAP_NET_RAW? Here's the comments for it: Nope.. > Func restricted_pointer() from lib/vspri

RE: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-15 Thread Steve Wise
> From: Jason Gunthorpe > On Tue, May 15, 2018 at 08:18:51AM -0500, Steve Wise wrote: > > > > > > On Mon, May 14, 2018 at 05:04:26PM -0500, Steve Wise wrote: > > > > > > > > > > > > > > > On 5/14/2018 3:41 PM, Jason Gunthorpe wrote: > > > > > > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-15 Thread Jason Gunthorpe
On Tue, May 15, 2018 at 08:18:51AM -0500, Steve Wise wrote: > > > > On Mon, May 14, 2018 at 05:04:26PM -0500, Steve Wise wrote: > > > > > > > > > > > > On 5/14/2018 3:41 PM, Jason Gunthorpe wrote: > > > > > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: > > > > >> This enhancement al

RE: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-15 Thread Steve Wise
> On Mon, May 14, 2018 at 05:04:26PM -0500, Steve Wise wrote: > > > > > > On 5/14/2018 3:41 PM, Jason Gunthorpe wrote: > > > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: > > >> This enhancement allows printing rdma device-specific state, if provided > > >> by the kernel. This is don

RE: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-15 Thread Steve Wise
> > On Mon, May 14, 2018 at 05:04:26PM -0500, Steve Wise wrote: > > > > > > > > > On 5/14/2018 3:41 PM, Jason Gunthorpe wrote: > > > > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: > > > >> This enhancement allows printing rdma device-specific state, if > provided > > > >> by the ke

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-15 Thread Leon Romanovsky
On Mon, May 14, 2018 at 05:04:26PM -0500, Steve Wise wrote: > > > On 5/14/2018 3:41 PM, Jason Gunthorpe wrote: > > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: > >> This enhancement allows printing rdma device-specific state, if provided > >> by the kernel. This is done in a generic

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-14 Thread Steve Wise
On 5/14/2018 3:41 PM, Jason Gunthorpe wrote: > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: >> This enhancement allows printing rdma device-specific state, if provided >> by the kernel. This is done in a generic manner, so rdma tool doesn't >> need to know about the details of eve

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-14 Thread Jason Gunthorpe
On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: > This enhancement allows printing rdma device-specific state, if provided > by the kernel. This is done in a generic manner, so rdma tool doesn't > need to know about the details of every type of rdma device. > > Driver attributes for a

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-14 Thread Steve Wise
On 5/13/2018 8:24 AM, Leon Romanovsky wrote: > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: >> This enhancement allows printing rdma device-specific state, if provided >> by the kernel. This is done in a generic manner, so rdma tool doesn't > Double space between "." and "This". >

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-13 Thread Leon Romanovsky
On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: > This enhancement allows printing rdma device-specific state, if provided > by the kernel. This is done in a generic manner, so rdma tool doesn't Double space between "." and "This". > need to know about the details of every type of rd

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-13 Thread Leon Romanovsky
On Thu, May 10, 2018 at 08:20:51AM -0600, David Ahern wrote: > On 5/10/18 8:19 AM, Steve Wise wrote: > > > > On 5/9/2018 11:08 PM, David Ahern wrote: > >> On 5/7/18 9:53 AM, Steve Wise wrote: > >>> @@ -152,7 +153,10 @@ int main(int argc, char **argv) > >>> pretty_output = true; >

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-10 Thread Steve Wise
On 5/9/2018 11:08 PM, David Ahern wrote: > On 5/7/18 9:53 AM, Steve Wise wrote: >> @@ -152,7 +153,10 @@ int main(int argc, char **argv) >> pretty_output = true; >> break; >> case 'd': >> -show_details = true; >> +

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-10 Thread David Ahern
On 5/10/18 8:19 AM, Steve Wise wrote: > > On 5/9/2018 11:08 PM, David Ahern wrote: >> On 5/7/18 9:53 AM, Steve Wise wrote: >>> @@ -152,7 +153,10 @@ int main(int argc, char **argv) >>> pretty_output = true; >>> break; >>> case 'd': >>> -

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-09 Thread David Ahern
On 5/7/18 9:53 AM, Steve Wise wrote: > @@ -152,7 +153,10 @@ int main(int argc, char **argv) > pretty_output = true; > break; > case 'd': > - show_details = true; > + if (show_details) > +

[PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-07 Thread Steve Wise
This enhancement allows printing rdma device-specific state, if provided by the kernel. This is done in a generic manner, so rdma tool doesn't need to know about the details of every type of rdma device. Driver attributes for a rdma resource are in the form of tuples, where the key is a string a