On Mon, Feb 8, 2021 at 10:48 AM Jakub Kicinski wrote:
>
> On Mon, 8 Feb 2021 10:41:35 -0800 Cong Wang wrote:
> > On Sat, Feb 6, 2021 at 9:26 PM wrote:
> > > + if (state && !(state & TCA_FLOWER_KEY_CT_FLAGS_TRACKED)) {
> > > + NL_SET_ERR_MSG_ATTR(extack, tb,
> > > +
On Mon, 8 Feb 2021 15:57:05 -0300 Marcelo Ricardo Leitner wrote:
> On Sun, Feb 07, 2021 at 01:13:23PM +0800, we...@ucloud.cn wrote:
> > --- a/net/sched/cls_flower.c
> > +++ b/net/sched/cls_flower.c
> > @@ -30,6 +30,11 @@
> >
> > #include
> >
> > +#define TCA_FLOWER_KEY_CT_FLAGS_MASK (TCA_FLOW
On Mon, Feb 08, 2021 at 10:47:59AM -0800, Jakub Kicinski wrote:
> On Mon, 8 Feb 2021 10:41:35 -0800 Cong Wang wrote:
> > On Sat, Feb 6, 2021 at 9:26 PM wrote:
> > > + if (state && !(state & TCA_FLOWER_KEY_CT_FLAGS_TRACKED)) {
> > > + NL_SET_ERR_MSG_ATTR(extack, tb,
> > > +
On Sun, Feb 07, 2021 at 01:13:23PM +0800, we...@ucloud.cn wrote:
> --- a/net/sched/cls_flower.c
> +++ b/net/sched/cls_flower.c
> @@ -30,6 +30,11 @@
>
> #include
>
> +#define TCA_FLOWER_KEY_CT_FLAGS_MASK (TCA_FLOWER_KEY_CT_FLAGS_NEW | \
> + TCA_FLOWER_KEY_CT_F
On Mon, 8 Feb 2021 10:41:35 -0800 Cong Wang wrote:
> On Sat, Feb 6, 2021 at 9:26 PM wrote:
> > + if (state && !(state & TCA_FLOWER_KEY_CT_FLAGS_TRACKED)) {
> > + NL_SET_ERR_MSG_ATTR(extack, tb,
> > + "ct_state no trk, no other flag are
> > set
On Sat, Feb 6, 2021 at 9:26 PM wrote:
> + if (state && !(state & TCA_FLOWER_KEY_CT_FLAGS_TRACKED)) {
> + NL_SET_ERR_MSG_ATTR(extack, tb,
> + "ct_state no trk, no other flag are set");
> + return -EINVAL;
> + }
> +
> +
From: wenxu
Reject the unsupported and invalid ct_state flags of cls flower rules.
Fixes: e0ace68af2ac ("net/sched: cls_flower: Add matching on conntrack info")
Signed-off-by: wenxu
---
net/sched/cls_flower.c | 36 +++-
1 file changed, 35 insertions(+), 1 deleti
