On Mon, 8 Feb 2021 10:41:35 -0800 Cong Wang wrote:
> On Sat, Feb 6, 2021 at 9:26 PM <we...@ucloud.cn> wrote:
> > + if (state && !(state & TCA_FLOWER_KEY_CT_FLAGS_TRACKED)) {
> > + NL_SET_ERR_MSG_ATTR(extack, tb,
> > + "ct_state no trk, no other flag are
> > set");
> > + return -EINVAL;
> > + }
> > +
> > + if (state & TCA_FLOWER_KEY_CT_FLAGS_NEW &&
> > + state & TCA_FLOWER_KEY_CT_FLAGS_ESTABLISHED) {
> > + NL_SET_ERR_MSG_ATTR(extack, tb,
> > + "ct_state new and est are exclusive");
>
> Please spell out the full words, "trk" and "est" are not good abbreviations.
It does match user space naming in OvS as well as iproute2:
{ "trk", TCA_FLOWER_KEY_CT_FLAGS_TRACKED },
{ "new", TCA_FLOWER_KEY_CT_FLAGS_NEW },
{ "est", TCA_FLOWER_KEY_CT_FLAGS_ESTABLISHED },
{ "inv", TCA_FLOWER_KEY_CT_FLAGS_INVALID },
{ "rpl", TCA_FLOWER_KEY_CT_FLAGS_REPLY },
IDK about netfilter itself.
