RE: [PATCH net v3] net: bridge: Fix ethernet header pointer before check skb forwardable

2019-01-16 Thread wangyunjian
Subject: Re: [PATCH net v3] net: bridge: Fix ethernet header pointer before > check skb forwardable > > On Wed, 16 Jan 2019 21:04:21 +0800 > wangyunjian wrote: > > > if (unlikely(netpoll_tx_running(to->br->dev))) { > > + skb_push(skb

Re: [PATCH net v3] net: bridge: Fix ethernet header pointer before check skb forwardable

2019-01-16 Thread Stephen Hemminger
On Wed, 16 Jan 2019 21:04:21 +0800 wangyunjian wrote: > if (unlikely(netpoll_tx_running(to->br->dev))) { > + skb_push(skb, ETH_HLEN); > if (!is_skb_forwardable(skb->dev, skb)) { > kfree_skb(skb); >

[PATCH net v3] net: bridge: Fix ethernet header pointer before check skb forwardable

2019-01-16 Thread wangyunjian
From: Yunjian Wang The skb header should be set to ethernet header before using is_skb_forwardable. Because the ethernet header length has been considered in is_skb_forwardable(including dev->hard_header_len length). To reproduce the issue: 1, add 2 ports on linux bridge br using following comma