On Wed, 16 Jan 2019 21:04:21 +0800
wangyunjian <wangyunj...@huawei.com> wrote:

>               if (unlikely(netpoll_tx_running(to->br->dev))) {
> +                     skb_push(skb, ETH_HLEN);
>                       if (!is_skb_forwardable(skb->dev, skb)) {
>                               kfree_skb(skb);
>                       } else {
> -                             skb_push(skb, ETH_HLEN);
>                               br_netpoll_send_skb(to, skb);
>                       }
>                       return;

The patch looks correct.

On minor style issue is that after moving skb_push out of the if statement,
both branches of the statement now contain a single line and therefore
the brackets are no longer necessary.  Suprised that checkpatch did
not complain about this.

Reply via email to