Re: [PATCH net v2] net: neigh: fix multiple neigh timer scheduling

2019-07-14 Thread Lorenzo Bianconi
> On 7/14/19 2:45 AM, Lorenzo Bianconi wrote: > > @@ -1124,7 +1125,9 @@ int __neigh_event_send(struct neighbour *neigh, > > struct sk_buff *skb) > > > > atomic_set(&neigh->probes, > >NEIGH_VAR(neigh->parms, UCAST_PROBES)); > > -

Re: [PATCH net v2] net: neigh: fix multiple neigh timer scheduling

2019-07-14 Thread David Miller
From: David Ahern Date: Sun, 14 Jul 2019 07:58:19 -0600 > On 7/14/19 2:45 AM, Lorenzo Bianconi wrote: >> @@ -1124,7 +1125,9 @@ int __neigh_event_send(struct neighbour *neigh, struct >> sk_buff *skb) >> >> atomic_set(&neigh->probes, >> NEIGH_

Re: [PATCH net v2] net: neigh: fix multiple neigh timer scheduling

2019-07-14 Thread David Ahern
On 7/14/19 2:45 AM, Lorenzo Bianconi wrote: > @@ -1124,7 +1125,9 @@ int __neigh_event_send(struct neighbour *neigh, struct > sk_buff *skb) > > atomic_set(&neigh->probes, > NEIGH_VAR(neigh->parms, UCAST_PROBES)); > - neigh

[PATCH net v2] net: neigh: fix multiple neigh timer scheduling

2019-07-14 Thread Lorenzo Bianconi
Neigh timer can be scheduled multiple times from userspace adding multiple neigh entries and forcing the neigh timer scheduling passing NTF_USE in the netlink requests. This will result in a refcount leak and in the following dump stack: [ 32.465295] NEIGH: BUG, double timer add, state is 8 [