Re: [PATCH net v1] hinic: fix a bug of ndo_stop

2020-05-08 Thread luobin (L)
The two modified points are relevant. We bump the timeout for SET_FUNC_STATE to ensure that cmd won't return failure when hw is busy. Otherwise hw may stomp host memory if we free memory regardless of the return value of SET_FUNC_STATE. I will mention the timeout changes in the commit messa

Re: [PATCH net v1] hinic: fix a bug of ndo_stop

2020-05-08 Thread Jakub Kicinski
On Thu, 7 May 2020 18:22:27 + Luo bin wrote: > if some function in ndo_stop interface returns failure because of > hardware fault, must go on excuting rest steps rather than return > failure directly, otherwise will cause memory leak > > Signed-off-by: Luo bin The code looks good, but would

[PATCH net v1] hinic: fix a bug of ndo_stop

2020-05-07 Thread Luo bin
if some function in ndo_stop interface returns failure because of hardware fault, must go on excuting rest steps rather than return failure directly, otherwise will cause memory leak Signed-off-by: Luo bin --- .../net/ethernet/huawei/hinic/hinic_hw_mgmt.c | 28 ++- .../net/ethern