Re: [PATCH net V2] openvswitch: fix skb_panic due to the incorrect actions attrlen

2017-08-15 Thread Pravin Shelar
On Tue, Aug 15, 2017 at 6:44 PM, Liping Zhang wrote: > 2017-08-16 7:35 GMT+08:00 Pravin Shelar : > [...] >>> diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c >>> index e4610676299b..f849ef52853f 100644 >>> --- a/net/openvswitch/actions.c >>> +++ b/net/openvswitch/actions.c >>> @@

Re: [PATCH net V2] openvswitch: fix skb_panic due to the incorrect actions attrlen

2017-08-15 Thread Liping Zhang
2017-08-16 7:35 GMT+08:00 Pravin Shelar : [...] >> diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c >> index e4610676299b..f849ef52853f 100644 >> --- a/net/openvswitch/actions.c >> +++ b/net/openvswitch/actions.c >> @@ -921,6 +921,7 @@ static int output_userspace(struct datapath *

Re: [PATCH net V2] openvswitch: fix skb_panic due to the incorrect actions attrlen

2017-08-15 Thread Pravin Shelar
On Tue, Aug 15, 2017 at 4:29 AM, Liping Zhang wrote: > From: Liping Zhang > > For sw_flow_actions, the actions_len only represents the kernel part's > size, and when we dump the actions to the userspace, we will do the > convertions, so it's true size may become bigger than the actions_len. > > B

[PATCH net V2] openvswitch: fix skb_panic due to the incorrect actions attrlen

2017-08-15 Thread Liping Zhang
From: Liping Zhang For sw_flow_actions, the actions_len only represents the kernel part's size, and when we dump the actions to the userspace, we will do the convertions, so it's true size may become bigger than the actions_len. But unfortunately, for OVS_PACKET_ATTR_ACTIONS, we use the actions_