Re: [PATCH net V2] openvswitch: fix skb_panic due to the incorrect actions attrlen

[Pravin Shelar]

On Tue, Aug 15, 2017 at 6:44 PM, Liping Zhang <zlpnob...@gmail.com> wrote:
> 2017-08-16 7:35 GMT+08:00 Pravin Shelar <pshe...@ovn.org>:
> [...]
>>> diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
>>> index e4610676299b..f849ef52853f 100644
>>> --- a/net/openvswitch/actions.c
>>> +++ b/net/openvswitch/actions.c
>>> @@ -921,6 +921,7 @@ static int output_userspace(struct datapath *dp, struct 
>>> sk_buff *skb,
>>>                         /* Include actions. */
>>>                         upcall.actions = actions;
>>>                         upcall.actions_len = actions_len;
>>> +                       upcall.actions_attrlen = OVS_CB(skb)->acts_origlen;
>> OVS_CB acts_origlen should be accessible in upcall_msg_size (), is
>> there reason to add this member to struct dp_upcall_info?
>
> Hmm... this means we should add an extra parameter to the upcall_msg_size()
> function, i.e.:
>  static size_t upcall_msg_size(const struct dp_upcall_info *upcall_info,
> -                             unsigned int hdrlen)
> +                             unsigned int hdrlen, int actions_attrlen)
>
I am fine with the parameter.

Thanks.