Re: [PATCH net 2/2] net/mlx5e: Use a private copy of netdev ops

2016-01-29 Thread Or Gerlitz
On Fri, Jan 29, 2016 at 6:00 AM, David Miller wrote: > This is not the canonical way to fix this. Please look at how > other drivers handle this situation before inventing your own > way of solving the problem. Dave, I was aware that other drivers do that differently, but the maintainer here pr

Re: [PATCH net 2/2] net/mlx5e: Use a private copy of netdev ops

2016-01-28 Thread David Miller
From: Or Gerlitz Date: Wed, 27 Jan 2016 17:02:25 +0200 > From: Saeed Mahameed > > Currently our netdevice ops is a static global variable which > is referenced by all mlx5e netdevice instances. This can be > problematic when different driver instances do not share same > HW capabilities (e.g SR

[PATCH net 2/2] net/mlx5e: Use a private copy of netdev ops

2016-01-27 Thread Or Gerlitz
From: Saeed Mahameed Currently our netdevice ops is a static global variable which is referenced by all mlx5e netdevice instances. This can be problematic when different driver instances do not share same HW capabilities (e.g SRIOV PF and VFs probed to the host). Remove the global variable and a