On Fri, Jan 29, 2016 at 6:00 AM, David Miller <da...@davemloft.net> wrote:
> This is not the canonical way to fix this. Please look at how > other drivers handle this situation before inventing your own > way of solving the problem. Dave, I was aware that other drivers do that differently, but the maintainer here preferred to go this way and I didn't see a deep reason why not. > The proper way is to have multiple netdevice ops instances, and simply > choose the one which is correct for the chip in question. yep, but - this can become little lengthy if you have N ndos shared among (say) three different profiles with m1, m2, m3 distinct ndos - so we thought it can be a bit more elegant to do selective assignment within a function and not as three globals. > You should also mark the ops as const. They should never _ever_ be > modified at runtime. okay Or.
