> On Aug 25, 2019, at 1:40 PM, Pravin Shelar wrote:
>
> Actually I am not sure about this change. caller of this function
> (ovs_ct_execute()) does skb-pull and push of L2 header, calling
> ovs_flow_key_update() is not safe here, it expect skb data to point to
> L2 header.
Thanks for the feedb
From: Pravin Shelar
Date: Sun, 25 Aug 2019 13:40:58 -0700
> On Sun, Aug 25, 2019 at 9:54 AM Pravin Shelar wrote:
>>
>> On Sat, Aug 24, 2019 at 9:58 AM Justin Pettit wrote:
>> >
>> > When IP fragments are reassembled before being sent to conntrack, the
>> > key from the last fragment is used. U
On Sun, Aug 25, 2019 at 9:54 AM Pravin Shelar wrote:
>
> On Sat, Aug 24, 2019 at 9:58 AM Justin Pettit wrote:
> >
> > When IP fragments are reassembled before being sent to conntrack, the
> > key from the last fragment is used. Unless there are reordering
> > issues, the last fragment received w
On Sat, Aug 24, 2019 at 9:58 AM Justin Pettit wrote:
>
> When IP fragments are reassembled before being sent to conntrack, the
> key from the last fragment is used. Unless there are reordering
> issues, the last fragment received will not contain the L4 ports, so the
> key for the reassembled dat
When IP fragments are reassembled before being sent to conntrack, the
key from the last fragment is used. Unless there are reordering
issues, the last fragment received will not contain the L4 ports, so the
key for the reassembled datagram won't contain them. This patch updates
the key once we ha
