> On Aug 25, 2019, at 1:40 PM, Pravin Shelar <pshe...@ovn.org> wrote: > > Actually I am not sure about this change. caller of this function > (ovs_ct_execute()) does skb-pull and push of L2 header, calling > ovs_flow_key_update() is not safe here, it expect skb data to point to > L2 header.
Thanks for the feedback, Pravin and David. Greg Rose has a revised version that will address the issues you raised and also make it so that we don't bother re-extracting the L2 headers. He'll hopefully get that out today once we've done some internal testing on it. --Justin
