Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-10 Thread Corinna Vinschen
On Sep 10 14:36, poma wrote: > On 10.09.2015 10:47, Corinna Vinschen wrote: > > On Sep 10 01:51, poma wrote: > >> [PATCH v2] r8169: Fix sleeping function called during get_stats64 > >> http://www.spinics.net/lists/netdev/msg342490.html > >> - the noise is still present > >> > >> Corinna, care to sh

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-10 Thread poma
On 10.09.2015 10:47, Corinna Vinschen wrote: > On Sep 10 01:51, poma wrote: >> [PATCH v2] r8169: Fix sleeping function called during get_stats64 >> http://www.spinics.net/lists/netdev/msg342490.html >> - the noise is still present >> >> Corinna, care to share kernel-core & kernel-modules you are te

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-10 Thread Corinna Vinschen
On Sep 10 01:51, poma wrote: > [PATCH v2] r8169: Fix sleeping function called during get_stats64 > http://www.spinics.net/lists/netdev/msg342490.html > - the noise is still present > > Corinna, care to share kernel-core & kernel-modules you are testing with, > to unravel the Gordian Knot? Somehow

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-09 Thread poma
On 09.09.2015 21:04, David Miller wrote: > From: poma > Date: Wed, 9 Sep 2015 20:34:36 +0200 > >> [ 230.110233] [] dma_generic_alloc_coherent+0x96/0x130 >> [ 230.110242] [] x86_swiotlb_alloc_coherent+0x25/0x50 >> [ 230.110250] [] dma_alloc_attrs+0x6d/0xe0 >> [ 230.110265] [] rtl8169_map_c

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-09 Thread poma
[PATCH v2] r8169: Fix sleeping function called during get_stats64 http://www.spinics.net/lists/netdev/msg342490.html - the noise is still present Corinna, care to share kernel-core & kernel-modules you are testing with, to unravel the Gordian Knot? -- To unsubscribe from this list: send the line

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-09 Thread poma
On 09/09/2015 09:08 PM, Corinna Vinschen wrote: > On Sep 9 20:34, poma wrote: >> On 09/09/2015 05:55 PM, Corinna Vinschen wrote: >>> On Sep 9 17:54, Corinna Vinschen wrote: On Sep 9 17:24, poma wrote: > [PATCH net] r8169: Fix sleeping function called during get_stats64 > http://marc

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-09 Thread Corinna Vinschen
On Sep 9 20:34, poma wrote: > On 09/09/2015 05:55 PM, Corinna Vinschen wrote: > > On Sep 9 17:54, Corinna Vinschen wrote: > >> On Sep 9 17:24, poma wrote: > >>> [PATCH net] r8169: Fix sleeping function called during get_stats64 > >>> http://marc.info/?l=linux-netdev&m=144180123410135&q=raw > >>>

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-09 Thread David Miller
From: poma Date: Wed, 9 Sep 2015 20:34:36 +0200 > [ 230.110233] [] dma_generic_alloc_coherent+0x96/0x130 > [ 230.110242] [] x86_swiotlb_alloc_coherent+0x25/0x50 > [ 230.110250] [] dma_alloc_attrs+0x6d/0xe0 > [ 230.110265] [] rtl8169_map_counters+0x3e/0x70 [r8169] > [ 230.110277] [] rtl8

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-09 Thread poma
On 09/09/2015 05:55 PM, Corinna Vinschen wrote: > On Sep 9 17:54, Corinna Vinschen wrote: >> On Sep 9 17:24, poma wrote: >>> [PATCH net] r8169: Fix sleeping function called during get_stats64 >>> http://marc.info/?l=linux-netdev&m=144180123410135&q=raw >>> - the noise is still present >> >> Are y

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-09 Thread Corinna Vinschen
On Sep 9 17:54, Corinna Vinschen wrote: > On Sep 9 17:24, poma wrote: > > [PATCH net] r8169: Fix sleeping function called during get_stats64 > > http://marc.info/?l=linux-netdev&m=144180123410135&q=raw > > - the noise is still present > > Are you really sure? The entire dma_alloc/dma_free stuff

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-09 Thread Corinna Vinschen
On Sep 9 17:24, poma wrote: > [PATCH net] r8169: Fix sleeping function called during get_stats64 > http://marc.info/?l=linux-netdev&m=144180123410135&q=raw > - the noise is still present Are you really sure? The entire dma_alloc/dma_free stuff has been moved away. There's no locking or sleeping

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-09 Thread poma
[PATCH net] r8169: Fix sleeping function called during get_stats64 http://marc.info/?l=linux-netdev&m=144180123410135&q=raw - the noise is still present -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-07 Thread poma
2nd batch: 0001-r8169-decouple-the-counters-data-and-the-device-priv.patch 0002-r8169-use-a-single-condition-to-check-the-completion.patch 0003-r8169-increase-the-lifespan-of-the-hardware-counters.patch - the noise is still present -- To unsubscribe from this list: send the line "unsubscribe netde

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-07 Thread poma
On 07.09.2015 10:50, Corinna Vinschen wrote: > On Sep 7 09:13, poma wrote: >> On 06.09.2015 12:19, Corinna Vinschen wrote: >>> On Sep 4 22:59, Francois Romieu wrote: Applies against davem's net as of f1ccbfce2fc787981d1182d09c1f6b67766783a8. drivers/net/ethernet/realtek/r81

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-07 Thread Corinna Vinschen
On Sep 7 09:13, poma wrote: > On 06.09.2015 12:19, Corinna Vinschen wrote: > > On Sep 4 22:59, Francois Romieu wrote: > >> Applies against davem's net as of > >> f1ccbfce2fc787981d1182d09c1f6b67766783a8. > >> > >> drivers/net/ethernet/realtek/r8169.c | 2 +- > >> 1 file changed, 1 insertion(+)

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-07 Thread poma
On 06.09.2015 12:19, Corinna Vinschen wrote: > On Sep 4 22:59, Francois Romieu wrote: >> net/core/net-sysfs.c::netstat_show fetches statistics under dev_base_lock. >> >> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=104031 >> Fixes: 6e85d5ad36a2 ("r8169: Add values missing in @get_stats64

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-06 Thread Francois Romieu
Corinna Vinschen : [...] > - I'm pretty new to this stuff, so I don't understand this: > > The dma_alloc_coherent(...,GFP_KERNEL) call is not new in the code, > it's there since at least 2010. It appears to work fine in the > context of @get_ethtool_stats. Why does this not work in the co

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-06 Thread Corinna Vinschen
On Sep 4 22:59, Francois Romieu wrote: > net/core/net-sysfs.c::netstat_show fetches statistics under dev_base_lock. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=104031 > Fixes: 6e85d5ad36a2 ("r8169: Add values missing in @get_stats64 from HW > counters") > Signed-off-by: Francois Ro

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-04 Thread David Miller
From: Francois Romieu Date: Sat, 5 Sep 2015 01:11:05 +0200 > David Miller : > [...] >> Is there any reason we cannot allocate this DMA buffer at probe or >> open time? > > None. > > As a fix for 6e85d5ad36a2 or as net-next material ? I think we should just do it right to fix this bug, it's ne

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-04 Thread Francois Romieu
David Miller : [...] > Is there any reason we cannot allocate this DMA buffer at probe or > open time? None. As a fix for 6e85d5ad36a2 or as net-next material ? -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org

Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-04 Thread David Miller
From: Francois Romieu Date: Fri, 4 Sep 2015 22:59:04 +0200 > net/core/net-sysfs.c::netstat_show fetches statistics under dev_base_lock. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=104031 > Fixes: 6e85d5ad36a2 ("r8169: Add values missing in @get_stats64 from HW > counters") > Signe

[PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-04 Thread Francois Romieu
net/core/net-sysfs.c::netstat_show fetches statistics under dev_base_lock. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=104031 Fixes: 6e85d5ad36a2 ("r8169: Add values missing in @get_stats64 from HW counters") Signed-off-by: Francois Romieu Cc: Corinna Vinschen --- Applies against da