Re: [PATCH net-next v4 5/6] selftests: refactor get_netdev_name function

2020-11-18 Thread Antonio Cardace
On Wed, Nov 18, 2020 at 08:56:10AM -0800, Jakub Kicinski wrote: > On Wed, 18 Nov 2020 10:03:20 +0100 Antonio Cardace wrote: > > Do I have to resend the whole serie as a new version or is there a > > quicker way to just resend a single patch? > > Just repost the series as v5, it's the least confusi

Re: [PATCH net-next v4 5/6] selftests: refactor get_netdev_name function

2020-11-18 Thread Jakub Kicinski
On Wed, 18 Nov 2020 10:03:20 +0100 Antonio Cardace wrote: > Do I have to resend the whole serie as a new version or is there a > quicker way to just resend a single patch? Just repost the series as v5, it's the least confusing way. Changelog from version to version would be good. You can put it i

Re: [PATCH net-next v4 5/6] selftests: refactor get_netdev_name function

2020-11-18 Thread Antonio Cardace
On Tue, Nov 17, 2020 at 06:35:20PM +0100, Michal Kubecek wrote: > On Tue, Nov 17, 2020 at 04:20:14PM +0100, Antonio Cardace wrote: > > As pointed out by Michal Kubecek, getting the name > > with the previous approach was racy, it's better > > and easier to get the name of the device with this > > p

Re: [PATCH net-next v4 5/6] selftests: refactor get_netdev_name function

2020-11-17 Thread Michal Kubecek
On Tue, Nov 17, 2020 at 04:20:14PM +0100, Antonio Cardace wrote: > As pointed out by Michal Kubecek, getting the name > with the previous approach was racy, it's better > and easier to get the name of the device with this > patch's approach. > > Essentialy the function doesn't need to exist > anym

[PATCH net-next v4 5/6] selftests: refactor get_netdev_name function

2020-11-17 Thread Antonio Cardace
As pointed out by Michal Kubecek, getting the name with the previous approach was racy, it's better and easier to get the name of the device with this patch's approach. Essentialy the function doesn't need to exist anymore as it's a simple 'ls' command. Signed-off-by: Antonio Cardace --- .../dr