On Tue, Nov 17, 2020 at 06:35:20PM +0100, Michal Kubecek wrote:
> On Tue, Nov 17, 2020 at 04:20:14PM +0100, Antonio Cardace wrote:
> > As pointed out by Michal Kubecek, getting the name
> > with the previous approach was racy, it's better
> > and easier to get the name of the device with this
> > patch's approach.
> >
> > Essentialy the function doesn't need to exist
> > anymore as it's a simple 'ls' command.
> >
> > Signed-off-by: Antonio Cardace <acard...@redhat.com>
> > ---
> > .../drivers/net/netdevsim/ethtool-common.sh | 20 ++-----------------
> > 1 file changed, 2 insertions(+), 18 deletions(-)
> >
> > diff --git
> > a/tools/testing/selftests/drivers/net/netdevsim/ethtool-common.sh
> > b/tools/testing/selftests/drivers/net/netdevsim/ethtool-common.sh
> > index fa44cf6e732c..3c287ac78117 100644
> > --- a/tools/testing/selftests/drivers/net/netdevsim/ethtool-common.sh
> > +++ b/tools/testing/selftests/drivers/net/netdevsim/ethtool-common.sh
> > @@ -20,23 +20,6 @@ function cleanup {
> >
> > trap cleanup EXIT
> >
> > -function get_netdev_name {
> > - local -n old=$1
> > -
> > - new=$(ls /sys/class/net)
> > -
> > - for netdev in $new; do
> > - for check in $old; do
> > - [ $netdev == $check ] && break
> > - done
> > -
> > - if [ $netdev != $check ]; then
> > - echo $netdev
> > - break
> > - fi
> > - done
> > -}
> > -
> > function check {
> > local code=$1
> > local str=$2
> > @@ -65,5 +48,6 @@ function make_netdev {
> > fi
> >
> > echo $NSIM_ID > /sys/bus/netdevsim/new_device
> > - echo `get_netdev_name old_netdevs`
> > + # get new device name
> > + echo $(ls /sys/bus/netdevsim/devices/netdevsim${NSIM_ID}/net/)
>
> Is there a reason for combining command substitution with echo? Couldn't
> we use one of
>
> ls /sys/bus/netdevsim/devices/netdevsim${NSIM_ID}/net/
> echo /sys/bus/netdevsim/devices/netdevsim${NSIM_ID}/net/*
>
> instead?
>
> Michal
>
Ouch, no that's just a mistake. I'll fix it.
Do I have to resend the whole serie as a new version or is there a
quicker way to just resend a single patch?
Thanks,
Antonio
