Re: [PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean

2020-09-15 Thread Jakub Kicinski
On Mon, 14 Sep 2020 21:24:28 -0700 Saeed Mahameed wrote: > I know Jakub and Dave do some compilation testing before merging but i > don't know how much driver coverage they have and if they use a > specific .config or they just manually create one on demand.. allmodconfig, it should be able to cat

Re: [PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean

2020-09-15 Thread David Miller
From: Saeed Mahameed Date: Tue, 15 Sep 2020 13:03:03 -0700 > On Tue, 2020-09-15 at 16:03 +0200, Andrew Lunn wrote: >> I would prefer we just enable W=1 by default for everything under >> driver/net. Maybe there is something we can set in >> driver/net/Makefile? >> > > > Yes we can have our own

Re: [PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean

2020-09-15 Thread Saeed Mahameed
On Tue, 2020-09-15 at 16:03 +0200, Andrew Lunn wrote: > On Mon, Sep 14, 2020 at 09:24:28PM -0700, Saeed Mahameed wrote: > > On Mon, 2020-09-14 at 18:44 -0700, Jesse Brandeburg wrote: > > > After applying the patches below, the drivers/net/ethernet > > > directory can be built as modules with W=1 wi

Re: [PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean

2020-09-15 Thread Andrew Lunn
> Yes we can have our own gcc options in the Makfile regardless of what > you put in W command line argument. > > Example: > > KBUILD_CFLAGS += -Wextra -Wunused -Wno-unused-parameter > KBUILD_CFLAGS += -Wmissing-declarations > KBUILD_CFLAGS += -Wmissing-format-attribute > KBUILD_CFLAGS += -Wmissi

Re: [PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean

2020-09-15 Thread Jesse Brandeburg
David Miller wrote: > Jesse, in all of these patches, I want to see the warning you are > fixing in the commit message. > > Especially for the sh_eth.c one because I have no idea what the > compiler is actually warning about just by reading your commit > message and patch on it's own. Ok, I'll re

Re: [PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean

2020-09-15 Thread David Miller
From: Jesse Brandeburg Date: Mon, 14 Sep 2020 18:44:45 -0700 > After applying the patches below, the drivers/net/ethernet > directory can be built as modules with W=1 with no warnings (so > far on x64_64 arch only!). > As Jakub pointed out, there is much more work to do to clean up > C=1, but tha

Re: [PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean

2020-09-15 Thread Jesse Brandeburg
Saeed Mahameed wrote: > Reviewed-by: Saeed Mahameed Thanks! In all fairness, Jakub reviewed this in v1 too but I made enough changes in v2 that I felt I had to drop the previous review ACKs. > Hi Jesse, > What was the criteria to select which drivers to enable in your .config > ? As Jakub said

Re: [PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean

2020-09-15 Thread Andrew Lunn
On Mon, Sep 14, 2020 at 09:24:28PM -0700, Saeed Mahameed wrote: > On Mon, 2020-09-14 at 18:44 -0700, Jesse Brandeburg wrote: > > After applying the patches below, the drivers/net/ethernet > > directory can be built as modules with W=1 with no warnings (so > > far on x64_64 arch only!). > > As Jakub

Re: [PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean

2020-09-14 Thread Saeed Mahameed
On Mon, 2020-09-14 at 18:44 -0700, Jesse Brandeburg wrote: > After applying the patches below, the drivers/net/ethernet > directory can be built as modules with W=1 with no warnings (so > far on x64_64 arch only!). > As Jakub pointed out, there is much more work to do to clean up > C=1, but that wi

[PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean

2020-09-14 Thread Jesse Brandeburg
After applying the patches below, the drivers/net/ethernet directory can be built as modules with W=1 with no warnings (so far on x64_64 arch only!). As Jakub pointed out, there is much more work to do to clean up C=1, but that will be another series of changes. This series removes 1,283 warnings