On Tue, 2020-09-15 at 16:03 +0200, Andrew Lunn wrote: > On Mon, Sep 14, 2020 at 09:24:28PM -0700, Saeed Mahameed wrote: > > On Mon, 2020-09-14 at 18:44 -0700, Jesse Brandeburg wrote: > > > After applying the patches below, the drivers/net/ethernet > > > directory can be built as modules with W=1 with no warnings (so > > > far on x64_64 arch only!). > > > As Jakub pointed out, there is much more work to do to clean up > > > C=1, but that will be another series of changes. > > > > > > This series removes 1,283 warnings and hopefully allows the > > > ethernet directory to move forward from here without more > > > warnings being added. There is only one objtool warning now. > > > > > > Some of these patches are already sent to Intel Wired Lan, but > > > the rest of the series titled drivers/net/ethernet affects other > > > drivers. The changes are all pretty straightforward. > > > > > > As part of testing this series I realized that I have ~1,500 more > > > kdoc warnings to fix due to being in other arch or not compiled > > > with my x86_64 .config. Feel free to run > > > $ 'git ls-files *.[ch] | grep drivers/net/ethernet | xargs > > > scripts/kernel-doc -none' > > > to see the remaining issues. > > > > > > > Reviewed-by: Saeed Mahameed <sae...@nvidia.com> > > > > Hi Jesse, > > What was the criteria to select which drivers to enable in your > > .config > > ? > > > > I think we need some automation here and have a well known .config > > that > > enables as many drivers as we can for static + compilation testing, > > otherwise we are going to need to repeat this patch every 2-3 > > months. > > Hi Saeed > > I would prefer we just enable W=1 by default for everything under > driver/net. Maybe there is something we can set in > driver/net/Makefile? >
Yes we can have our own gcc options in the Makfile regardless of what you put in W command line argument. Example: KBUILD_CFLAGS += -Wextra -Wunused -Wno-unused-parameter KBUILD_CFLAGS += -Wmissing-declarations KBUILD_CFLAGS += -Wmissing-format-attribute KBUILD_CFLAGS += -Wmissing-prototypes KBUILD_CFLAGS += -Wold-style-definition KBUILD_CFLAGS += -Wmissing-include-dirs
