Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-25 Thread Vlad Buslov
On Fri 22 May 2020 at 22:33, Cong Wang wrote: > On Wed, May 20, 2020 at 12:24 AM Vlad Buslov wrote: >> >> >> On Tue 19 May 2020 at 21:58, Cong Wang wrote: >> > On Tue, May 19, 2020 at 2:04 AM Vlad Buslov wrote: >> >> I considered that approach initially but decided against it for >> >> followin

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-23 Thread Jamal Hadi Salim
On 2020-05-22 12:16 p.m., Vlad Buslov wrote: On Thu 21 May 2020 at 20:02, Jakub Kicinski wrote: On Thu, 21 May 2020 17:36:12 +0300 Vlad Buslov wrote: Hi Edward, Cong, Do you really need to dump classifiers? If you care about stats the actions could be sufficient if the offload code was fix

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-22 Thread Cong Wang
On Thu, May 21, 2020 at 7:36 AM Vlad Buslov wrote: > > Hi Edward, Cong, > > On Mon 18 May 2020 at 18:37, Edward Cree wrote: > > On 15/05/2020 12:40, Vlad Buslov wrote: > >> In order to > >> significantly improve filter dump rate this patch sets implement new > >> mode of TC filter dump operation

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-22 Thread Cong Wang
On Wed, May 20, 2020 at 12:24 AM Vlad Buslov wrote: > > > On Tue 19 May 2020 at 21:58, Cong Wang wrote: > > On Tue, May 19, 2020 at 2:04 AM Vlad Buslov wrote: > >> I considered that approach initially but decided against it for > >> following reasons: > >> > >> - Generic data is covered by curre

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-22 Thread Vlad Buslov
On Thu 21 May 2020 at 20:02, Jakub Kicinski wrote: > On Thu, 21 May 2020 17:36:12 +0300 Vlad Buslov wrote: >> Hi Edward, Cong, >> >> On Mon 18 May 2020 at 18:37, Edward Cree wrote: >> > On 15/05/2020 12:40, Vlad Buslov wrote: >> >> In order to >> >> significantly improve filter dump rate this

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-21 Thread Jakub Kicinski
On Thu, 21 May 2020 17:36:12 +0300 Vlad Buslov wrote: > Hi Edward, Cong, > > On Mon 18 May 2020 at 18:37, Edward Cree wrote: > > On 15/05/2020 12:40, Vlad Buslov wrote: > >> In order to > >> significantly improve filter dump rate this patch sets implement new > >> mode of TC filter dump operati

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-21 Thread Vlad Buslov
Hi Edward, Cong, On Mon 18 May 2020 at 18:37, Edward Cree wrote: > On 15/05/2020 12:40, Vlad Buslov wrote: >> In order to >> significantly improve filter dump rate this patch sets implement new >> mode of TC filter dump operation named "terse dump" mode. In this mode >> only parameters necessary

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-20 Thread Vlad Buslov
On Tue 19 May 2020 at 21:39, Cong Wang wrote: > On Tue, May 19, 2020 at 2:10 AM Vlad Buslov wrote: >> >> >> On Mon 18 May 2020 at 21:46, Cong Wang wrote: >> > On Sun, May 17, 2020 at 11:44 PM Vlad Buslov wrote: >> >> >> >> >> >> On Sun 17 May 2020 at 22:13, Cong Wang wrote: >> >> > On Fri, M

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-20 Thread Vlad Buslov
On Tue 19 May 2020 at 21:58, Cong Wang wrote: > On Tue, May 19, 2020 at 2:04 AM Vlad Buslov wrote: >> I considered that approach initially but decided against it for >> following reasons: >> >> - Generic data is covered by current terse dump implementation. >> Everything else will be act or c

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-19 Thread Cong Wang
On Tue, May 19, 2020 at 2:04 AM Vlad Buslov wrote: > I considered that approach initially but decided against it for > following reasons: > > - Generic data is covered by current terse dump implementation. > Everything else will be act or cls specific which would result long > list of flag val

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-19 Thread Cong Wang
On Tue, May 19, 2020 at 2:10 AM Vlad Buslov wrote: > > > On Mon 18 May 2020 at 21:46, Cong Wang wrote: > > On Sun, May 17, 2020 at 11:44 PM Vlad Buslov wrote: > >> > >> > >> On Sun 17 May 2020 at 22:13, Cong Wang wrote: > >> > On Fri, May 15, 2020 at 4:40 AM Vlad Buslov wrote: > >> >> > >> >>

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-19 Thread Vlad Buslov
On Tue 19 May 2020 at 17:30, Edward Cree wrote: > On 19/05/2020 10:04, Vlad Buslov wrote: >> On Mon 18 May 2020 at 18:37, Edward Cree wrote: >>> I.e. if next year it turns out that some >>> user needs one parameter that's been omitted here, but not the whole dump, >>> are they going to want t

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-19 Thread Edward Cree
On 19/05/2020 10:04, Vlad Buslov wrote: > On Mon 18 May 2020 at 18:37, Edward Cree wrote: >> I.e. if next year it turns out that some >> user needs one parameter that's been omitted here, but not the whole dump, >> are they going to want to add another mode to the uapi? > Why not just extend ter

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-19 Thread Vlad Buslov
On Mon 18 May 2020 at 21:46, Cong Wang wrote: > On Sun, May 17, 2020 at 11:44 PM Vlad Buslov wrote: >> >> >> On Sun 17 May 2020 at 22:13, Cong Wang wrote: >> > On Fri, May 15, 2020 at 4:40 AM Vlad Buslov wrote: >> >> >> >> Output rate of current upstream kernel TC filter dump implementation i

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-19 Thread Vlad Buslov
On Mon 18 May 2020 at 18:37, Edward Cree wrote: > On 15/05/2020 12:40, Vlad Buslov wrote: >> In order to >> significantly improve filter dump rate this patch sets implement new >> mode of TC filter dump operation named "terse dump" mode. In this mode >> only parameters necessary to identify the

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-18 Thread Cong Wang
On Mon, May 18, 2020 at 8:38 AM Edward Cree wrote: > > On 15/05/2020 12:40, Vlad Buslov wrote: > > In order to > > significantly improve filter dump rate this patch sets implement new > > mode of TC filter dump operation named "terse dump" mode. In this mode > > only parameters necessary to identi

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-18 Thread Cong Wang
On Sun, May 17, 2020 at 11:44 PM Vlad Buslov wrote: > > > On Sun 17 May 2020 at 22:13, Cong Wang wrote: > > On Fri, May 15, 2020 at 4:40 AM Vlad Buslov wrote: > >> > >> Output rate of current upstream kernel TC filter dump implementation if > >> relatively low (~100k rules/sec depending on confi

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-18 Thread Edward Cree
On 15/05/2020 12:40, Vlad Buslov wrote: > In order to > significantly improve filter dump rate this patch sets implement new > mode of TC filter dump operation named "terse dump" mode. In this mode > only parameters necessary to identify the filter (handle, action cookie, > etc.) and data that can

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-17 Thread Vlad Buslov
On Fri 15 May 2020 at 20:25, David Miller wrote: > From: Vlad Buslov > Date: Fri, 15 May 2020 14:40:10 +0300 > >> Output rate of current upstream kernel TC filter dump implementation if >> relatively low (~100k rules/sec depending on configuration). This >> constraint impacts performance of sof

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-17 Thread Vlad Buslov
On Fri 15 May 2020 at 20:04, Jakub Kicinski wrote: > On Fri, 15 May 2020 14:40:10 +0300 Vlad Buslov wrote: >> Output rate of current upstream kernel TC filter dump implementation if >> relatively low (~100k rules/sec depending on configuration). This >> constraint impacts performance of software

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-17 Thread Vlad Buslov
On Sun 17 May 2020 at 22:13, Cong Wang wrote: > On Fri, May 15, 2020 at 4:40 AM Vlad Buslov wrote: >> >> Output rate of current upstream kernel TC filter dump implementation if >> relatively low (~100k rules/sec depending on configuration). This >> constraint impacts performance of software swi

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-17 Thread Cong Wang
On Fri, May 15, 2020 at 4:40 AM Vlad Buslov wrote: > > Output rate of current upstream kernel TC filter dump implementation if > relatively low (~100k rules/sec depending on configuration). This > constraint impacts performance of software switch implementation that > rely on TC for their datapath

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-15 Thread David Miller
From: Vlad Buslov Date: Fri, 15 May 2020 14:40:10 +0300 > Output rate of current upstream kernel TC filter dump implementation if > relatively low (~100k rules/sec depending on configuration). This > constraint impacts performance of software switch implementation that > rely on TC for their data

Re: [PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-15 Thread Jakub Kicinski
On Fri, 15 May 2020 14:40:10 +0300 Vlad Buslov wrote: > Output rate of current upstream kernel TC filter dump implementation if > relatively low (~100k rules/sec depending on configuration). This > constraint impacts performance of software switch implementation that > rely on TC for their datapath

[PATCH net-next v2 0/4] Implement classifier-action terse dump mode

2020-05-15 Thread Vlad Buslov
Output rate of current upstream kernel TC filter dump implementation if relatively low (~100k rules/sec depending on configuration). This constraint impacts performance of software switch implementation that rely on TC for their datapath implementation and periodically call TC filter dump to update