Re: [PATCH net-next v2] net/mlx5e: Fix uninitialised struct field moder.comps

2021-04-20 Thread Leon Romanovsky
On Tue, Apr 20, 2021 at 05:28:43PM +0800, Zhu Yanjun wrote: > On Tue, Apr 20, 2021 at 5:21 PM Leon Romanovsky wrote: > > > > On Tue, Apr 20, 2021 at 03:09:03PM +0800, Zhu Yanjun wrote: > > > On Tue, Apr 20, 2021 at 3:01 PM wangyunjian > > > wrote: > > > > > > > > From: Yunjian Wang > > > > > >

Re: [PATCH net-next v2] net/mlx5e: Fix uninitialised struct field moder.comps

2021-04-20 Thread Zhu Yanjun
On Tue, Apr 20, 2021 at 5:21 PM Leon Romanovsky wrote: > > On Tue, Apr 20, 2021 at 03:09:03PM +0800, Zhu Yanjun wrote: > > On Tue, Apr 20, 2021 at 3:01 PM wangyunjian wrote: > > > > > > From: Yunjian Wang > > > > > > The 'comps' struct field in 'moder' is not being initialized in > > > mlx5e_get

Re: [PATCH net-next v2] net/mlx5e: Fix uninitialised struct field moder.comps

2021-04-20 Thread Leon Romanovsky
On Tue, Apr 20, 2021 at 03:09:03PM +0800, Zhu Yanjun wrote: > On Tue, Apr 20, 2021 at 3:01 PM wangyunjian wrote: > > > > From: Yunjian Wang > > > > The 'comps' struct field in 'moder' is not being initialized in > > mlx5e_get_def_rx_moderation() and mlx5e_get_def_tx_moderation(). > > So initializ

Re: [PATCH net-next v2] net/mlx5e: Fix uninitialised struct field moder.comps

2021-04-20 Thread Zhu Yanjun
On Tue, Apr 20, 2021 at 3:01 PM wangyunjian wrote: > > From: Yunjian Wang > > The 'comps' struct field in 'moder' is not being initialized in > mlx5e_get_def_rx_moderation() and mlx5e_get_def_tx_moderation(). > So initialize 'moder' to zero to avoid the issue. > > Addresses-Coverity: ("Uninitiali

[PATCH net-next v2] net/mlx5e: Fix uninitialised struct field moder.comps

2021-04-20 Thread wangyunjian
From: Yunjian Wang The 'comps' struct field in 'moder' is not being initialized in mlx5e_get_def_rx_moderation() and mlx5e_get_def_tx_moderation(). So initialize 'moder' to zero to avoid the issue. Addresses-Coverity: ("Uninitialized scalar variable") Signed-off-by: Yunjian Wang --- v2: update