On Tue, Apr 20, 2021 at 3:01 PM wangyunjian <wangyunj...@huawei.com> wrote:
>
> From: Yunjian Wang <wangyunj...@huawei.com>
>
> The 'comps' struct field in 'moder' is not being initialized in
> mlx5e_get_def_rx_moderation() and mlx5e_get_def_tx_moderation().
> So initialize 'moder' to zero to avoid the issue.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Signed-off-by: Yunjian Wang <wangyunj...@huawei.com>
> ---
> v2: update mlx5e_get_def_tx_moderation() also needs fixing
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> index 5db63b9f3b70..17a817b7e539 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> @@ -4868,7 +4868,7 @@ static bool slow_pci_heuristic(struct mlx5_core_dev
> *mdev)
>
> static struct dim_cq_moder mlx5e_get_def_tx_moderation(u8 cq_period_mode)
> {
> - struct dim_cq_moder moder;
> + struct dim_cq_moder moder = {};
If I remember correctly, some gcc compiler will report errors about this "{}".
Zhu Yanjun
>
> moder.cq_period_mode = cq_period_mode;
> moder.pkts = MLX5E_PARAMS_DEFAULT_TX_CQ_MODERATION_PKTS;
> @@ -4881,7 +4881,7 @@ static struct dim_cq_moder
> mlx5e_get_def_tx_moderation(u8 cq_period_mode)
>
> static struct dim_cq_moder mlx5e_get_def_rx_moderation(u8 cq_period_mode)
> {
> - struct dim_cq_moder moder;
> + struct dim_cq_moder moder = {};
>
> moder.cq_period_mode = cq_period_mode;
> moder.pkts = MLX5E_PARAMS_DEFAULT_RX_CQ_MODERATION_PKTS;
> --
> 2.23.0
>
