Re: [PATCH net-next v2] ethtool: Protect {get,set}_phy_tunable with PHY device mutex

2016-11-24 Thread David Miller
From: Florian Fainelli Date: Tue, 22 Nov 2016 13:55:31 -0800 > PHY drivers should be able to rely on the caller of {get,set}_tunable to > have acquired the PHY device mutex, in order to both serialize against > concurrent calls of these functions, but also against PHY state machine > changes. All

Re: [PATCH net-next v2] ethtool: Protect {get,set}_phy_tunable with PHY device mutex

2016-11-24 Thread Allan W. Nielsen
On 22/11/16 13:55, Florian Fainelli wrote: > EXTERNAL EMAIL > > > PHY drivers should be able to rely on the caller of {get,set}_tunable to > have acquired the PHY device mutex, in order to both serialize against > concurrent calls of these functions, but also against PHY state machine > changes.

Re: [PATCH net-next v2] ethtool: Protect {get,set}_phy_tunable with PHY device mutex

2016-11-23 Thread Andrew Lunn
On Tue, Nov 22, 2016 at 01:55:31PM -0800, Florian Fainelli wrote: > PHY drivers should be able to rely on the caller of {get,set}_tunable to > have acquired the PHY device mutex, in order to both serialize against > concurrent calls of these functions, but also against PHY state machine > changes.

[PATCH net-next v2] ethtool: Protect {get,set}_phy_tunable with PHY device mutex

2016-11-22 Thread Florian Fainelli
PHY drivers should be able to rely on the caller of {get,set}_tunable to have acquired the PHY device mutex, in order to both serialize against concurrent calls of these functions, but also against PHY state machine changes. All ethtool PHY-level functions do this, except {get,set}_tunable, so we m