On 22/11/16 13:55, Florian Fainelli wrote:
> EXTERNAL EMAIL
>
>
> PHY drivers should be able to rely on the caller of {get,set}_tunable to
> have acquired the PHY device mutex, in order to both serialize against
> concurrent calls of these functions, but also against PHY state machine
> changes. All ethtool PHY-level functions do this, except
> {get,set}_tunable, so we make them consistent here as well.
>
> We need to update the Microsemi PHY driver in the same commit to avoid
> introducing either deadlocks, or lack of proper locking.
>
> Fixes: 968ad9da7e0e ("ethtool: Implements
> ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE")
> Fixes: 310d9ad57ae0 ("net: phy: Add downshift get/set support in Microsemi
> PHYs driver")
> Signed-off-by: Florian Fainelli <f.faine...@gmail.com>
Reviewed-by: Allan W. Nielsen <allan.niel...@microsemi.com>
